Use enum class for subtypes of CPDF_Annot.

Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.

Committed: https://pdfium.googlesource.com/pdfium/+/956553e715787cfc4dd8423d5e9a04a0131878c3

[jaepark, 2016-08-30 18:19:06]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 18:19:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 18:39:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 18:39:59]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-30 18:46:44]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[dsinclair, 2016-08-30 20:40:30]

lgtm w/ nit.

https://codereview.chromium.org/2295953002/diff/1/fpdfsdk/cpdfsdk_annothandle...
File fpdfsdk/cpdfsdk_annothandlermgr.cpp (left):

https://codereview.chromium.org/2295953002/diff/1/fpdfsdk/cpdfsdk_annothandle...
fpdfsdk/cpdfsdk_annothandlermgr.cpp:49: return
GetAnnotHandler(FSDK_XFAWIDGET_TYPENAME)->NewAnnot(pAnnot, pPageView);
nit: Can this TYPENAME be removed now?

[jaepark, 2016-08-30 20:52:29]

Description was changed from

==========
Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.
==========

to

==========
Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.
==========

[jaepark, 2016-08-30 20:54:30]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-30 20:54:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 21:08:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 21:08:51]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-30 21:21:53]

Rebased, and removed IPDFSDK_AnnotHandler::GetType.

https://codereview.chromium.org/2295953002/diff/1/fpdfsdk/cpdfsdk_annothandle...
File fpdfsdk/cpdfsdk_annothandlermgr.cpp (left):

https://codereview.chromium.org/2295953002/diff/1/fpdfsdk/cpdfsdk_annothandle...
fpdfsdk/cpdfsdk_annothandlermgr.cpp:49: return
GetAnnotHandler(FSDK_XFAWIDGET_TYPENAME)->NewAnnot(pAnnot, pPageView);
On 2016/08/30 20:40:29, dsinclair wrote:
> nit: Can this TYPENAME be removed now?

FSDK_XFAWIDGET_TYPENAME is used in CPDFSDK_XFAWidgetHandler::GetType(). However,
GetType() is not used anymore, so I've just removed them as well.

[dsinclair, 2016-08-31 13:49:02]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-08-31 13:49:03]

lgtm

[commit-bot: I haz the power, 2016-08-31 13:49:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 13:49:30]

Description was changed from

==========
Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.
==========

to

==========
Use enum class for subtypes of CPDF_Annot.

Comparing CFX_ByteString for annotation subtypes is inefficient and
error-prone. This CL uses enum class to compare annotation subtypes.

Also, remove unused IPDFSDK_AnnotHandler::GetType() and
FSDK_XFAWIDGET_TYPENAME.

Committed:
https://pdfium.googlesource.com/pdfium/+/956553e715787cfc4dd8423d5e9a04a01318...
==========

[commit-bot: I haz the power, 2016-08-31 13:49:30]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/956553e715787cfc4dd8423d5e9a04a01318...