core/fpdfdoc/cpdf_annotlist.cpp - Issue 2295953002: Use enum class for subtypes of CPDF_Annot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfdoc/cpdf_annotlist.cpp

Issue 2295953002: Use enum class for subtypes of CPDF_Annot. (Closed)

Patch Set: Use enum class for subtypes of CPDF_Annot. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfdoc/cpdf_annotlist.cpp

diff --git a/core/fpdfdoc/cpdf_annotlist.cpp b/core/fpdfdoc/cpdf_annotlist.cpp

index 4c569892c2056c9b235d822756657811db36a800..61122ed59b99ee32a031b0a8a8f6f8e5f227d3d8 100644

--- a/core/fpdfdoc/cpdf_annotlist.cpp

+++ b/core/fpdfdoc/cpdf_annotlist.cpp

@@ -110,7 +110,7 @@ void CPDF_AnnotList::DisplayPass(CPDF_Page* pPage,

CPDF_RenderOptions* pOptions,

FX_RECT* clip_rect) {

for (const auto& pAnnot : m_AnnotList) {

- bool bWidget = pAnnot->GetSubtype() == "Widget";

+ bool bWidget = pAnnot->GetSubtype() == CPDF_Annot::Subtype::WIDGET;

if ((bWidgetPass && !bWidget) || (!bWidgetPass && bWidget))

continue;

« no previous file with comments | « core/fpdfdoc/cpdf_annot.cpp ('k') | core/fpdfdoc/include/cpdf_annot.h » ('j') | no next file with comments »