fpdfsdk/cpdfsdk_annot.cpp - Issue 2295953002: Use enum class for subtypes of CPDF_Annot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: fpdfsdk/cpdfsdk_annot.cpp

Issue 2295953002: Use enum class for subtypes of CPDF_Annot. (Closed)

Patch Set: Use enum class for subtypes of CPDF_Annot. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: fpdfsdk/cpdfsdk_annot.cpp

diff --git a/fpdfsdk/cpdfsdk_annot.cpp b/fpdfsdk/cpdfsdk_annot.cpp

index 5ca439d8f70f848e8a0ae25c537303bb5979793a..59d8f24e824440b0a4c0f9476ce4e93924bab567 100644

--- a/fpdfsdk/cpdfsdk_annot.cpp

+++ b/fpdfsdk/cpdfsdk_annot.cpp

@@ -58,8 +58,8 @@ CPDF_Annot* CPDFSDK_Annot::GetPDFAnnot() const {

return nullptr;

}

-CFX_ByteString CPDFSDK_Annot::GetAnnotSubtype() const {

- return "";

+CPDF_Annot::Subtype CPDFSDK_Annot::GetAnnotSubtype() const {

+ return CPDF_Annot::Subtype::UNKNOWN;

}

bool CPDFSDK_Annot::IsSignatureWidget() const {

« no previous file with comments | « fpdfsdk/cba_annotiterator.cpp ('k') | fpdfsdk/cpdfsdk_annothandlermgr.cpp » ('j') | no next file with comments »