Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(772)

Issue 2295693003: DevTools: cleanup WI.NetworkMapping nits (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: cleanup WI.NetworkMapping nits This patch: - introduces WI.IsolatedFileSystemManager.fileSystems() method. This allows to avoid type casts. - splits out WI.NetworkMapping._addMappingsForFileSystem to avoid creating artificial event. BUG=none R=dgozman, pfeldman Committed: https://crrev.com/12918608faeb9c66111e71a4ef1e9393dca5cbe5 Cr-Commit-Position: refs/heads/master@{#415541}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -12 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js View 3 chunks +12 lines, -6 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/settings/SettingsScreen.js View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
lushnikov
please, take a look. FYI: this is a part of crrev.com/2241573002
4 years, 3 months ago (2016-08-30 22:54:43 UTC) #1
dgozman
https://codereview.chromium.org/2295693003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js (right): https://codereview.chromium.org/2295693003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js#newcode23 third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:23: this._addMappingsForFilesystem(fileSystem); You don't issue fileSystemMappingChanged here anymore.
4 years, 3 months ago (2016-08-31 00:08:35 UTC) #4
lushnikov
https://codereview.chromium.org/2295693003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js (right): https://codereview.chromium.org/2295693003/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js#newcode23 third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:23: this._addMappingsForFilesystem(fileSystem); On 2016/08/31 00:08:35, dgozman wrote: > You don't ...
4 years, 3 months ago (2016-08-31 00:19:30 UTC) #5
dgozman
lgtm
4 years, 3 months ago (2016-08-31 01:28:34 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295693003/1
4 years, 3 months ago (2016-08-31 02:16:32 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 02:21:04 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 02:24:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/12918608faeb9c66111e71a4ef1e9393dca5cbe5
Cr-Commit-Position: refs/heads/master@{#415541}

Powered by Google App Engine
This is Rietveld 408576698