Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1029)

Issue 2290323003: DevTools: use eventListener arrays to avoid memory leaks in dispose methods (Closed)

Created:
4 years, 3 months ago by lushnikov
Modified:
4 years, 3 months ago
Reviewers:
dgozman, pfeldman
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, pfeldman, kozyatinskiy+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: use eventListener arrays to avoid memory leaks in dispose methods This patch: - switches to using event listener arrays in FileSystemWorkspaceBinding and NetworkMapping classes. - removes IsolatedFileSystemManager.dispose method. IFSM is a singleton which is supposed to be always alive. BUG=none R=dgozman, pfeldman Committed: https://crrev.com/9e0ff32923aa6f94f4f53cf412888afec5138e71 Cr-Commit-Position: refs/heads/master@{#415494}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -24 lines) Patch
M third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js View 2 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js View 1 chunk +0 lines, -8 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 11 (6 generated)
lushnikov
please, take a look! FYI: this is a part of crrev.com/2241573002
4 years, 3 months ago (2016-08-30 21:59:27 UTC) #1
dgozman
lgtm
4 years, 3 months ago (2016-08-30 23:02:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290323003/1
4 years, 3 months ago (2016-08-30 23:33:50 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 23:38:44 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 23:40:13 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9e0ff32923aa6f94f4f53cf412888afec5138e71
Cr-Commit-Position: refs/heads/master@{#415494}

Powered by Google App Engine
This is Rietveld 408576698