DevTools: kill WI.IsolatedFileSystemManager FileSystemsLoaded event

DevTools: kill WI.IsolatedFileSystemManager FileSystemsLoaded event

This patch:
- Kills WI.IsolatedFileSystemManager.Events.FileSystemsLoaded. Instead,
  clients should use WI.IsolatedFileSystemManager.waitForFileSystems()
  promise.
- Makes WI.IsolatedFileSystemManager to not send FileSystemAdded events
  during initial file system loading

BUG=none
R=pfeldman, dgozman

Committed: https://crrev.com/a7693f2fcaa894a4667b7095d0819ab4c80fe07a
Cr-Commit-Position: refs/heads/master@{#415862}

[lushnikov, 2016-08-31 00:26:58]

please, take a look!

FYI: this is a part of crrev.com/2241573002

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
(right):

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:167:
var embedderPath = /** @type {string} */ (event.data);
this is just inlined _fileSystemRemoved method.

[lushnikov, 2016-08-31 00:27:05]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 00:27:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dgozman, 2016-08-31 01:39:46]

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
(right):

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:35: for
(var fileSystem of this._fileSystemManager.fileSystems())
Let's have an array of initial file systems returned from waitForFileSystems.

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
(right):

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:55:
this._fileSystemsLoadedPromise = new Promise(fulfill =>
this._fileSystemsLoadedCallback = fulfill);
this._fileSystemsLoadedPromise = this._requestFileSystems();



_requestFileSystems: function()
{
    var fulfill;
    var promise = new Promise(f => fulfill = f);
    InspectorFrontendHost.requestFileSystems();
   
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.FileSystemsLoaded,
onFileSystemsLoaded, this);
    return promise;

    function onFileSystemsLoaded()
    {
        ...
        fulfill();
    }
}

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:145:
this.dispatchEventToListeners(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded,
fileSystem)
semicolon

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:159:
this._innerAddFileSystem(fileSystem, true)
semicolon

[commit-bot: I haz the power, 2016-08-31 01:59:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 01:59:15]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-08-31 17:35:10]

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js
(right):

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:35: for
(var fileSystem of this._fileSystemManager.fileSystems())
On 2016/08/31 01:39:46, dgozman wrote:
> Let's have an array of initial file systems returned from waitForFileSystems.

Done.

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
(right):

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:55:
this._fileSystemsLoadedPromise = new Promise(fulfill =>
this._fileSystemsLoadedCallback = fulfill);
On 2016/08/31 01:39:46, dgozman wrote:
> this._fileSystemsLoadedPromise = this._requestFileSystems();
> 
> 
> 
> _requestFileSystems: function()
> {
>     var fulfill;
>     var promise = new Promise(f => fulfill = f);
>     InspectorFrontendHost.requestFileSystems();
>    
>
InspectorFrontendHost.events.addEventListener(InspectorFrontendHostAPI.Events.FileSystemsLoaded,
> onFileSystemsLoaded, this);
>     return promise;
> 
>     function onFileSystemsLoaded()
>     {
>         ...
>         fulfill();
>     }
> }

Done.

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:145:
this.dispatchEventToListeners(WebInspector.IsolatedFileSystemManager.Events.FileSystemAdded,
fileSystem)
On 2016/08/31 01:39:46, dgozman wrote:
> semicolon

Done.

https://codereview.chromium.org/2296983003/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:159:
this._innerAddFileSystem(fileSystem, true)
On 2016/08/31 01:39:46, dgozman wrote:
> semicolon

Done.

[lushnikov, 2016-08-31 17:44:44]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 17:45:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 19:14:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 19:14:01]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-08-31 20:28:46]

lgtm

https://codereview.chromium.org/2296983003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
(right):

https://codereview.chromium.org/2296983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:109:
Promise.all(promises).then(fileSystems => fulfill(fileSystems.filter(fs =>
!!fs)));
style: no nested arrow functions please

[lushnikov, 2016-08-31 21:46:01]

https://codereview.chromium.org/2296983003/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js
(right):

https://codereview.chromium.org/2296983003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/workspace/IsolatedFileSystemManager.js:109:
Promise.all(promises).then(fileSystems => fulfill(fileSystems.filter(fs =>
!!fs)));
On 2016/08/31 20:28:46, dgozman wrote:
> style: no nested arrow functions please

yikes. done.

[lushnikov, 2016-08-31 21:46:11]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-08-31 21:46:11]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2296983003/#ps40001
(title: "remove nested arrow")

[commit-bot: I haz the power, 2016-08-31 21:47:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 01:09:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:09:20]

Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[lushnikov, 2016-09-01 01:35:24]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-09-01 01:35:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:47:24]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 02:50:54]

Description was changed from

==========
DevTools: kill WI.IsolatedFileSystemManager FileSystemsLoaded event

This patch:
- Kills WI.IsolatedFileSystemManager.Events.FileSystemsLoaded. Instead,
  clients should use WI.IsolatedFileSystemManager.waitForFileSystems()
  promise.
- Makes WI.IsolatedFileSystemManager to not send FileSystemAdded events
  during initial file system loading

BUG=none
R=pfeldman, dgozman
==========

to

==========
DevTools: kill WI.IsolatedFileSystemManager FileSystemsLoaded event

This patch:
- Kills WI.IsolatedFileSystemManager.Events.FileSystemsLoaded. Instead,
  clients should use WI.IsolatedFileSystemManager.waitForFileSystems()
  promise.
- Makes WI.IsolatedFileSystemManager to not send FileSystemAdded events
  during initial file system loading

BUG=none
R=pfeldman, dgozman

Committed: https://crrev.com/a7693f2fcaa894a4667b7095d0819ab4c80fe07a
Cr-Commit-Position: refs/heads/master@{#415862}
==========

[commit-bot: I haz the power, 2016-09-01 02:50:55]

Patchset 3 (id:??) landed as
https://crrev.com/a7693f2fcaa894a4667b7095d0819ab4c80fe07a
Cr-Commit-Position: refs/heads/master@{#415862}