Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Issue 2295643002: [turbofan] Extend LoadElimination to introduce TypeGuards. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, bgeron
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Extend LoadElimination to introduce TypeGuards. If the type of a tracked field or element value is less precise than the advertised type of the field or element load, then we replace the load operation with a TypeGuard that guards the advertised type. R=jarin@chromium.org BUG=v8:5267 Committed: https://crrev.com/b98d64f909db4ae2eda9fabcbab9cf0f81cb76ac Cr-Commit-Position: refs/heads/master@{#39032}

Patch Set 1 #

Patch Set 2 : REBASE #

Patch Set 3 : Fix assertion in SimplifiedLowering. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -17 lines) Patch
M src/compiler/load-elimination.h View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/load-elimination.cc View 4 chunks +29 lines, -12 lines 0 comments Download
M src/compiler/simplified-lowering.cc View 1 2 1 chunk +7 lines, -5 lines 0 comments Download
M test/unittests/compiler/load-elimination-unittest.cc View 1 chunk +58 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 20 (14 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-30 04:36:05 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix for the LoadElimination issue that Bram noticed. Please take a ...
4 years, 3 months ago (2016-08-30 04:37:40 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-31 05:43:06 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295643002/40001
4 years, 3 months ago (2016-08-31 05:46:12 UTC) #17
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 05:48:13 UTC) #18
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:48:37 UTC) #20
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/b98d64f909db4ae2eda9fabcbab9cf0f81cb76ac
Cr-Commit-Position: refs/heads/master@{#39032}

Powered by Google App Engine
This is Rietveld 408576698