Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 2293343002: [turbofan] Remove remaining uses of Class type from the compiler. (Closed)

Created:
4 years, 3 months ago by Benedikt Meurer
Modified:
4 years, 3 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Remove remaining uses of Class type from the compiler. We (mis)used Type::Class to track stable field maps in the past. But that always more or less unsupport and wrong for various reasons, mostly because the class types do not really present static information and thus it is possible to violate fundamental assumptions of the type system (i.e. intersecting class types and other types produces "interesting" results). Now it is possible to finally nuke the class types completely and thus simplify (and ideally correctify) the type system further. Note to performance sheriff: We do expect to see some performance regressions from this change. This is because we do not yet have a sane replacement mechanism to track known field maps and utilize them during LoadElimination. This will be accomplished in a follow up CL. BUG=v8:5270, v8:5267 R=jarin@chromium.org Committed: https://crrev.com/2b93899057a4c52cf523114b582bbca48b035cb2 Cr-Commit-Position: refs/heads/master@{#39031}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -46 lines) Patch
M src/compiler/access-info.h View 4 chunks +5 lines, -1 line 0 comments Download
M src/compiler/access-info.cc View 6 chunks +31 lines, -21 lines 0 comments Download
M src/compiler/js-global-object-specialization.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M src/compiler/typed-optimization.cc View 3 chunks +4 lines, -12 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M src/types.h View 1 chunk +5 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
Benedikt Meurer
4 years, 3 months ago (2016-08-31 04:02:37 UTC) #1
Benedikt Meurer
Hey Jaro, Removing the weird class type completely from the compiler directory. This also unblocks ...
4 years, 3 months ago (2016-08-31 04:08:05 UTC) #4
Jarin
lgtm
4 years, 3 months ago (2016-08-31 05:41:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2293343002/1
4 years, 3 months ago (2016-08-31 05:42:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-31 05:44:28 UTC) #10
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 05:44:47 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2b93899057a4c52cf523114b582bbca48b035cb2
Cr-Commit-Position: refs/heads/master@{#39031}

Powered by Google App Engine
This is Rietveld 408576698