Source/core/html/shadow/PasswordGeneratorButtonElement.cpp - Issue 22955006: Chrome::client() should return a ChromeClient reference.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/PasswordGeneratorButtonElement.cpp

Issue 22955006: Chrome::client() should return a ChromeClient reference. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 7 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/shadow/PasswordGeneratorButtonElement.cpp

diff --git a/Source/core/html/shadow/PasswordGeneratorButtonElement.cpp b/Source/core/html/shadow/PasswordGeneratorButtonElement.cpp

index 8f6b3c6f85e3342bcd7f8ada78e64e996a6839e0..bcc124fa10f9d353432d2842c5d08a69ac0db3e0 100644

--- a/Source/core/html/shadow/PasswordGeneratorButtonElement.cpp

+++ b/Source/core/html/shadow/PasswordGeneratorButtonElement.cpp

@@ -171,8 +171,8 @@ void PasswordGeneratorButtonElement::defaultEventHandler(Event* event)

RefPtr<PasswordGeneratorButtonElement> protector(this);

if (event->type() == eventNames().clickEvent) {

- if (ChromeClient* chromeClient = document()->page() ? document()->page()->chrome().client() : 0)

- chromeClient->openPasswordGenerator(input.get());

+ if (Page* page = document()->page())

+ page->chrome().client().openPasswordGenerator(input.get());

event->setDefaultHandled();

}

« no previous file with comments | « Source/core/html/PasswordInputType.cpp ('k') | Source/core/inspector/InspectorOverlay.cpp » ('j') | no next file with comments »