Add some copy support for vulkan msaa

Add some copy support for vulkan msaa

This allows us to do copies from:
    msaa->msaa with same sample count
    msaa->no-msaa with a resolve

Still missing support for no-msaa to msaa which will require a copyAsDraw
which is currently stalled and fixing possible driver bugs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294533002

Committed: https://skia.googlesource.com/skia/+/4bcd62e3313da60c3aa96ccd12b7ea440c7266d4

[egdaniel, 2016-08-29 19:42:52]

egdaniel@google.com changed reviewers:
+ bsalomon@google.com, jvanverth@google.com

[bsalomon, 2016-08-30 13:07:20]

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h#newcode316
src/gpu/GrGpu.h:316: virtual bool initCopySurfaceDstDesc(const GrRenderTarget*
src, GrSurfaceDesc* desc) const = 0;
Is this part of the change incidental or necessary?

[egdaniel, 2016-08-30 13:40:46]

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h#newcode316
src/gpu/GrGpu.h:316: virtual bool initCopySurfaceDstDesc(const GrRenderTarget*
src, GrSurfaceDesc* desc) const = 0;
On 2016/08/30 13:07:20, bsalomon wrote:
> Is this part of the change incidental or necessary?

It is not necessary, but it does make some of the code slightly cleaner not
having to check if the src is a RT or not. But in general if we are only using
the function in cases where the src is an RT I feel likes its better to restrict
it and then we can expand it back to Surface if we find a good reason.

[bsalomon, 2016-08-30 15:29:21]

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h#newcode316
src/gpu/GrGpu.h:316: virtual bool initCopySurfaceDstDesc(const GrRenderTarget*
src, GrSurfaceDesc* desc) const = 0;
On 2016/08/30 13:40:46, egdaniel wrote:
> On 2016/08/30 13:07:20, bsalomon wrote:
> > Is this part of the change incidental or necessary?
> 
> It is not necessary, but it does make some of the code slightly cleaner not
> having to check if the src is a RT or not. But in general if we are only using
> the function in cases where the src is an RT I feel likes its better to
restrict
> it and then we can expand it back to Surface if we find a good reason.

If we're going to narrow the definition of the function to those use cases, can
we rename it to something like "initDescForDstCopy"?

[egdaniel, 2016-08-30 15:44:30]

Description was changed from

==========
Add some copy support for vulkan msaa

This allows us to do copies from:
    msaa->msaa with same sample count
    msaa->no-msaa with a resolve

Still missing support for no-msaa to msaa which will require a copyAsDraw
which is currently stalled and fixing possible driver bugs.

BUG=skia:
==========

to

==========
Add some copy support for vulkan msaa

This allows us to do copies from:
    msaa->msaa with same sample count
    msaa->no-msaa with a resolve

Still missing support for no-msaa to msaa which will require a copyAsDraw
which is currently stalled and fixing possible driver bugs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294533002
==========

[egdaniel, 2016-08-30 15:45:13]

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h
File src/gpu/GrGpu.h (right):

https://codereview.chromium.org/2294533002/diff/20001/src/gpu/GrGpu.h#newcode316
src/gpu/GrGpu.h:316: virtual bool initCopySurfaceDstDesc(const GrRenderTarget*
src, GrSurfaceDesc* desc) const = 0;
On 2016/08/30 15:29:21, bsalomon wrote:
> On 2016/08/30 13:40:46, egdaniel wrote:
> > On 2016/08/30 13:07:20, bsalomon wrote:
> > > Is this part of the change incidental or necessary?
> > 
> > It is not necessary, but it does make some of the code slightly cleaner not
> > having to check if the src is a RT or not. But in general if we are only
using
> > the function in cases where the src is an RT I feel likes its better to
> restrict
> > it and then we can expand it back to Surface if we find a good reason.
> 
> If we're going to narrow the definition of the function to those use cases,
can
> we rename it to something like "initDescForDstCopy"?
> 

Done.

[egdaniel, 2016-08-31 13:04:48]

ping

[bsalomon, 2016-08-31 13:48:09]

lgtm

[egdaniel, 2016-08-31 13:51:32]

The CQ bit was checked by egdaniel@google.com

[commit-bot: I haz the power, 2016-08-31 13:51:35]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 14:37:35]

Description was changed from

==========
Add some copy support for vulkan msaa

This allows us to do copies from:
    msaa->msaa with same sample count
    msaa->no-msaa with a resolve

Still missing support for no-msaa to msaa which will require a copyAsDraw
which is currently stalled and fixing possible driver bugs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294533002
==========

to

==========
Add some copy support for vulkan msaa

This allows us to do copies from:
    msaa->msaa with same sample count
    msaa->no-msaa with a resolve

Still missing support for no-msaa to msaa which will require a copyAsDraw
which is currently stalled and fixing possible driver bugs.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294533002

Committed:
https://skia.googlesource.com/skia/+/4bcd62e3313da60c3aa96ccd12b7ea440c7266d4
==========

[commit-bot: I haz the power, 2016-08-31 14:37:37]

Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/4bcd62e3313da60c3aa96ccd12b7ea440c7266d4