Refuse to resolve some types of invalid DNS addresses.

MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
Committed: https://crrev.com/d6e9161aff5787fa445cbbbdf8dbc48ac95d38ac
Cr-Commit-Position: refs/heads/master@{#417723}

[mmenke, 2016-08-31 21:21:31]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 21:22:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 21:38:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 21:38:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mmenke, 2016-08-31 21:59:28]

The CQ bit was checked by mmenke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 22:00:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 23:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 23:22:41]

Dry run: This issue passed the CQ dry run.

[mmenke, 2016-09-09 19:54:11]

Description was changed from

==========
Refuse to resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl has. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
==========

to

==========
MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
==========

[mmenke, 2016-09-09 19:55:16]

mmenke@chromium.org changed reviewers:
+ juliatuttle@chromium.org

[mmenke, 2016-09-09 19:55:17]

Julia, does this seem reasonable?

[Julia Tuttle, 2016-09-09 20:24:39]

lgtm modulo nit.

https://codereview.chromium.org/2294343003/diff/40001/net/dns/dns_util.cc
File net/dns/dns_util.cc (right):

https://codereview.chromium.org/2294343003/diff/40001/net/dns/dns_util.cc#new...
net/dns/dns_util.cc:36: // Refuse to convert invalid host names.
This is commented out; remove it?

[mmenke, 2016-09-09 20:38:44]

https://codereview.chromium.org/2294343003/diff/40001/net/dns/dns_util.cc
File net/dns/dns_util.cc (right):

https://codereview.chromium.org/2294343003/diff/40001/net/dns/dns_util.cc#new...
net/dns/dns_util.cc:36: // Refuse to convert invalid host names.
On 2016/09/09 20:24:38, Julia Tuttle wrote:
> This is commented out; remove it?

Oops, thanks!  I hadn't realized this was actually the method used to check
hostname validity, initially.

[mmenke, 2016-09-09 20:39:17]

The CQ bit was checked by mmenke@chromium.org

[mmenke, 2016-09-09 20:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
juliatuttle@chromium.org
Link to the patchset: https://codereview.chromium.org/2294343003/#ps60001
(title: "Oops")

[commit-bot: I haz the power, 2016-09-09 20:39:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 21:56:02]

Description was changed from

==========
MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
==========

to

==========
MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
==========

[commit-bot: I haz the power, 2016-09-09 21:56:03]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-09 21:57:29]

Description was changed from

==========
MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606
==========

to

==========
MockHostResolver:  Don't resolve some types of invalid DNS addresses.

The MockHostResolver didn't have the DNS validity check that
HostResolverImpl had. This was causing a fuzzer to send invalid domains
to the CookieStore code, causing DCHECKs.

Also prevent invalid DNS addresses from being put in the HOSTS list,
when using the internal resolver, as that list is checked before
checking if DNS addresses are valid.

BUG=632606

Committed: https://crrev.com/d6e9161aff5787fa445cbbbdf8dbc48ac95d38ac
Cr-Commit-Position: refs/heads/master@{#417723}
==========

[commit-bot: I haz the power, 2016-09-09 21:57:30]

Patchset 4 (id:??) landed as
https://crrev.com/d6e9161aff5787fa445cbbbdf8dbc48ac95d38ac
Cr-Commit-Position: refs/heads/master@{#417723}