Refuse to resolve some types of invalid DNS addresses.

net/dns/dns_hosts_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/dns/dns_hosts.h"
 
 #include "net/base/ip_address.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace net {
@@ skipping 30 matching lines @@
       "1.0.0.1\t CoMpANy # normalized to 'company' \n"
       "::1\tlocalhost ip6-localhost ip6-loopback # comment # within a comment\n"
       "\t fe00::0 ip6-localnet\r\n"
       "2048::2 example\n"
       "2048::1 company example # ignored for 'example' \n"
       "127.0.0.1 cache1\n"
       "127.0.0.1 cache2 # should reuse parsed IP\n"
       "256.0.0.0 cache3 # bogus IP should not clear parsed IP cache\n"
       "127.0.0.1 cache4 # should still be reused\n"
       "127.0.0.2 cache5\n"
+      "127.0.0.3 .foo # entries with leading dot are ignored\n"
+      "127.0.0.3 . # just a dot is ignored\n"
+      "127.0.0.4 bar. # trailing dot is allowed, for now\n"
       "gibberish";
 
   const ExpectedHostsEntry kEntries[] = {
-    { "localhost", ADDRESS_FAMILY_IPV4, "127.0.0.1" },
-    { "localhost.localdomain", ADDRESS_FAMILY_IPV4, "127.0.0.1" },
-    { "company", ADDRESS_FAMILY_IPV4, "1.0.0.1" },
-    { "localhost", ADDRESS_FAMILY_IPV6, "::1" },
-    { "ip6-localhost", ADDRESS_FAMILY_IPV6, "::1" },
-    { "ip6-loopback", ADDRESS_FAMILY_IPV6, "::1" },
-    { "ip6-localnet", ADDRESS_FAMILY_IPV6, "fe00::0" },
-    { "company", ADDRESS_FAMILY_IPV6, "2048::1" },
-    { "example", ADDRESS_FAMILY_IPV6, "2048::2" },
-    { "cache1", ADDRESS_FAMILY_IPV4, "127.0.0.1" },
-    { "cache2", ADDRESS_FAMILY_IPV4, "127.0.0.1" },
-    { "cache4", ADDRESS_FAMILY_IPV4, "127.0.0.1" },
-    { "cache5", ADDRESS_FAMILY_IPV4, "127.0.0.2" },
+      {"localhost", ADDRESS_FAMILY_IPV4, "127.0.0.1"},
+      {"localhost.localdomain", ADDRESS_FAMILY_IPV4, "127.0.0.1"},
+      {"company", ADDRESS_FAMILY_IPV4, "1.0.0.1"},
+      {"localhost", ADDRESS_FAMILY_IPV6, "::1"},
+      {"ip6-localhost", ADDRESS_FAMILY_IPV6, "::1"},
+      {"ip6-loopback", ADDRESS_FAMILY_IPV6, "::1"},
+      {"ip6-localnet", ADDRESS_FAMILY_IPV6, "fe00::0"},
+      {"company", ADDRESS_FAMILY_IPV6, "2048::1"},
+      {"example", ADDRESS_FAMILY_IPV6, "2048::2"},
+      {"cache1", ADDRESS_FAMILY_IPV4, "127.0.0.1"},
+      {"cache2", ADDRESS_FAMILY_IPV4, "127.0.0.1"},
+      {"cache4", ADDRESS_FAMILY_IPV4, "127.0.0.1"},
+      {"cache5", ADDRESS_FAMILY_IPV4, "127.0.0.2"},
+      {"bar.", ADDRESS_FAMILY_IPV4, "127.0.0.4"},
   };
 
   DnsHosts expected_hosts, actual_hosts;
   PopulateExpectedHosts(kEntries, arraysize(kEntries), &expected_hosts);
   ParseHosts(kContents, &actual_hosts);
   ASSERT_EQ(expected_hosts, actual_hosts);
 }
 
 TEST(DnsHostsTest, ParseHosts_CommaIsToken) {
   const std::string kContents = "127.0.0.1 comma1,comma2";
@@ skipping 96 matching lines @@
 TEST(DnsHostsTest, HostsParser_EndsWithNewlineAndToken) {
   DnsHosts hosts;
   ParseHosts("127.0.0.1 localhost\ntoken", &hosts);
   EXPECT_EQ(1u, hosts.size());
 }
 
 }  // namespace
 
 }  // namespace net