net/dns/host_resolver_impl.cc - Issue 2294343003: Refuse to resolve some types of invalid DNS addresses.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/dns/host_resolver_impl.cc

Issue 2294343003: Refuse to resolve some types of invalid DNS addresses. (Closed)

Patch Set: Oops Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/dns/host_resolver_impl.cc

diff --git a/net/dns/host_resolver_impl.cc b/net/dns/host_resolver_impl.cc

index 8be7731dee183efba47aacfd2b403b4cded7defb..80c9a8b9e2dcc0e1c41512f4ad7cac00abcbe4c4 100644

--- a/net/dns/host_resolver_impl.cc

+++ b/net/dns/host_resolver_impl.cc

@@ -1919,8 +1919,7 @@ int HostResolverImpl::Resolve(const RequestInfo& info,

DCHECK(out_req);

// Check that the caller supplied a valid hostname to resolve.

- std::string labeled_hostname;

- if (!DNSDomainFromDot(info.hostname(), &labeled_hostname))

+ if (!IsValidDNSDomain(info.hostname()))

return ERR_NAME_NOT_RESOLVED;

LogStartRequest(source_net_log, info);

« no previous file with comments | « net/dns/dns_util.cc ('k') | net/dns/mock_host_resolver.cc » ('j') | no next file with comments »