made point light shadows

made point light shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294323003

Committed: https://skia.googlesource.com/skia/+/1e5abf15d11861247084e97215ec45a98912adb1

[vjiaoblack, 2016-08-31 20:43:59]

Description was changed from

==========
made point light shadows

BUG=skia:
==========

to

==========
made point light shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294323003
==========

[vjiaoblack, 2016-08-31 20:53:57]

vjiaoblack@google.com changed reviewers:
+ jvanverth@google.com, robertphillips@google.com

[robertphillips, 2016-08-31 22:18:20]

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:75: 
const SkRect&

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:87: } else if
(this->fLights->light(0).type() == SkLights::Light::kPoint_LightType) {
How does all this interact with the CTM and saveLayers.

I.e.,

What if we add a translate on the canvas of 500, 500 to draw a 10x10 rect vs.
drawing the 500,500,510,510 rect directly?

Similarly, if we have a large canvas but create a small layer at 500,500 to draw
several rects that are dropped down onto the main canvas together.

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:95: 
Why 400?

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:258: const SkPaint &paint) {
Isn't the cull parameter optional?

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
File src/utils/SkShadowPaintFilterCanvas.h (right):

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.h:42: 
const SkRect&

[vjiaoblack, 2016-09-01 19:22:48]

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:75: 
On 2016/08/31 22:18:19, robertphillips wrote:
> const SkRect&

Done.

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:87: } else if
(this->fLights->light(0).type() == SkLights::Light::kPoint_LightType) {
On 2016/08/31 22:18:19, robertphillips wrote:
> How does all this interact with the CTM and saveLayers.
> 
> I.e.,
> 
> What if we add a translate on the canvas of 500, 500 to draw a 10x10 rect vs.
> drawing the 500,500,510,510 rect directly?
> 
> Similarly, if we have a large canvas but create a small layer at 500,500 to
draw
> several rects that are dropped down onto the main canvas together.

I'll test it.

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:95: 
On 2016/08/31 22:18:19, robertphillips wrote:
> Why 400?

because it's the current height of the diffuse map. I'll have to pass it in
later

https://codereview.chromium.org/2294323003/diff/1/src/utils/SkShadowPaintFilt...
src/utils/SkShadowPaintFilterCanvas.cpp:258: const SkPaint &paint) {
On 2016/08/31 22:18:19, robertphillips wrote:
> Isn't the cull parameter optional?

Done.

[robertphillips, 2016-09-02 16:23:46]

https://codereview.chromium.org/2294323003/diff/60001/src/utils/SkShadowPaint...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/60001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:53: if (light.type() !=
SkLights::Light::kDirectional_LightType) {
Just 4 - you want it to remain an int

[vjiaoblack, 2016-09-02 17:22:00]

I've changed the * 4.0f (in SPFCanvas::ComputeDepthMapSize for point lights) to
* 4, since it's being put into an SkISize.

https://codereview.chromium.org/2294323003/diff/60001/src/utils/SkShadowPaint...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/60001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:53: if (light.type() !=
SkLights::Light::kDirectional_LightType) {
On 2016/09/02 16:23:46, robertphillips wrote:
> Just 4 - you want it to remain an int

Done.

[robertphillips, 2016-09-06 17:51:11]

https://codereview.chromium.org/2294323003/diff/80001/src/core/SkShadowShader...
File src/core/SkShadowShader.cpp (right):

https://codereview.chromium.org/2294323003/diff/80001/src/core/SkShadowShader...
src/core/SkShadowShader.cpp:307: 
Where are the 0.375fs coming from ?

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:88: SkPoint3 lightPos =
this->fLights->light(0).pos();
This set call seems odd ...

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:91: // shadow maps for point lights are
4x the size of the diffuse map
How was 4x arrived at?

[vjiaoblack, 2016-09-06 19:30:33]

Made requested comments!
> explaining the 0.375 transform, and the 4x depthMap size for point lights

https://codereview.chromium.org/2294323003/diff/80001/src/core/SkShadowShader...
File src/core/SkShadowShader.cpp (right):

https://codereview.chromium.org/2294323003/diff/80001/src/core/SkShadowShader...
src/core/SkShadowShader.cpp:307: 
On 2016/09/06 17:51:11, robertphillips wrote:
> Where are the 0.375fs coming from ?

Done.

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
File src/utils/SkShadowPaintFilterCanvas.cpp (right):

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:88: SkPoint3 lightPos =
this->fLights->light(0).pos();
On 2016/09/06 17:51:11, robertphillips wrote:
> This set call seems odd ...

Done.

https://codereview.chromium.org/2294323003/diff/80001/src/utils/SkShadowPaint...
src/utils/SkShadowPaintFilterCanvas.cpp:91: // shadow maps for point lights are
4x the size of the diffuse map
On 2016/09/06 17:51:11, robertphillips wrote:
> How was 4x arrived at?

Done.

[jvanverth1, 2016-09-07 13:43:05]

lgtm

[vjiaoblack, 2016-09-07 13:43:26]

The CQ bit was checked by vjiaoblack@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-07 13:43:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 14:17:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-07 14:17:26]

Dry run: This issue passed the CQ dry run.

[vjiaoblack, 2016-09-07 14:47:05]

The CQ bit was checked by vjiaoblack@google.com

[commit-bot: I haz the power, 2016-09-07 14:47:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-07 14:48:13]

Description was changed from

==========
made point light shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294323003
==========

to

==========
made point light shadows

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2294323003

Committed:
https://skia.googlesource.com/skia/+/1e5abf15d11861247084e97215ec45a98912adb1
==========

[commit-bot: I haz the power, 2016-09-07 14:48:14]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/1e5abf15d11861247084e97215ec45a98912adb1