Converted Observatory class-view element

Converted Observatory class-view element

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/1341e94321694d7d5a3570c9cee6a95c87612d9c

[cbernaschina, 2016-08-31 03:31:58]

cbernaschina@google.com changed reviewers:
+ johnmccutchan@google.com, rmacnak@google.com, turnidge@google.com

[rmacnak, 2016-08-31 18:21:11]

I get pages missing data if I visit internal classes (Function, Class, etc).

[rmacnak, 2016-08-31 23:51:39]

lgtm

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
File runtime/observatory/lib/src/elements/class_instances.dart (right):

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/class_instances.dart:95: final
instanceNumber = _cls.newSpace.current.instances +
instanceCount

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/class_view.dart:180: if (_cls.mixin !=
null) {
I'd remove this. If class's mixin isn't null, that makes it a mixin application,
not a mixin.

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/class_view.dart:372: members.add(
This pattern seems to get repeated a lot in many of the views.  Maybe in another
CL, create a helper like

Element createMemberList(String title, List<Element> members) {
  return new DivElement()..classes = ['memberItem']
           ..children = [
             new DivElement()..classes = ['memberName']
               ..text = title,
             new DivElement()..classes = ['memberValue']
               ..children = members;
            ]
      );
}

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
File runtime/observatory/lib/src/elements/top_retaining_instances.dart (right):

https://chromiumcodereview.appspot.com/2294073003/diff/20001/runtime/observat...
runtime/observatory/lib/src/elements/top_retaining_instances.dart:100: new
SpanElement()..text = '${Utils.formatSize(r.retainedSize)} ',
non-breaking space

[cbernaschina, 2016-09-01 00:03:45]

Description was changed from

==========
Converted Observatory class-view element
==========

to

==========
Converted Observatory class-view element

R=rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/1341e94321694d7d5a3570c9cee6a95c87612d9c
==========

[cbernaschina, 2016-09-01 00:03:46]

Committed patchset #3 (id:40001) manually as
1341e94321694d7d5a3570c9cee6a95c87612d9c (presubmit successful).

[cbernaschina, 2016-09-01 00:04:08]

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_instances.dart (right):

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_instances.dart:95: final
instanceNumber = _cls.newSpace.current.instances +
On 2016/08/31 23:51:39, rmacnak wrote:
> instanceCount

Done.

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/class_view.dart (right):

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.dart:180: if (_cls.mixin !=
null) {
On 2016/08/31 23:51:39, rmacnak wrote:
> I'd remove this. If class's mixin isn't null, that makes it a mixin
application,
> not a mixin.

Done.

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/class_view.dart:372: members.add(
On 2016/08/31 23:51:39, rmacnak wrote:
> This pattern seems to get repeated a lot in many of the views.  Maybe in
another
> CL, create a helper like
> 
> Element createMemberList(String title, List<Element> members) {
>   return new DivElement()..classes = ['memberItem']
>            ..children = [
>              new DivElement()..classes = ['memberName']
>                ..text = title,
>              new DivElement()..classes = ['memberValue']
>                ..children = members;
>             ]
>       );
> }
> 

Acknowledged.

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
File runtime/observatory/lib/src/elements/top_retaining_instances.dart (right):

https://codereview.chromium.org/2294073003/diff/20001/runtime/observatory/lib...
runtime/observatory/lib/src/elements/top_retaining_instances.dart:100: new
SpanElement()..text = '${Utils.formatSize(r.retainedSize)} ',
On 2016/08/31 23:51:39, rmacnak wrote:
> non-breaking space

Done.