runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart - Issue 2294073003: Converted Observatory class-view element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart

Issue 2294073003: Converted Observatory class-view element (Closed)

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/models/repositories/sample_profile.dart ('k') | runtime/observatory/lib/src/models/repositories/top_retaining_instances.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart

diff --git a/runtime/observatory/lib/src/models/repositories/flag.dart b/runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart

similarity index 63%

copy from runtime/observatory/lib/src/models/repositories/flag.dart

copy to runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart

index 358b93355d168d666ecb59fc0352af401100a805..c0449f82f08cfab63dd33f7868b7918596fb8b59 100644

--- a/runtime/observatory/lib/src/models/repositories/flag.dart

+++ b/runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart

@@ -4,6 +4,6 @@

part of models;

-abstract class FlagsRepository {

- Future<Iterable<Flag>> list();

+abstract class StronglyReachableInstancesRepository {

+ Future<InstanceSet> get(IsolateRef isolate, ClassRef cls, {int limit: 100});

}