runtime/observatory/lib/src/models/repositories/sample_profile.dart - Issue 2294073003: Converted Observatory class-view element

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/models/repositories/sample_profile.dart

Issue 2294073003: Converted Observatory class-view element (Closed)

Patch Set: Addressed comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/models/objects/object.dart ('k') | runtime/observatory/lib/src/models/repositories/strongly_reachable_instances.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/models/repositories/sample_profile.dart

diff --git a/runtime/observatory/lib/src/models/repositories/sample_profile.dart b/runtime/observatory/lib/src/models/repositories/sample_profile.dart

index 3ec7cfd6f79644d52e554578f8f1a76e67de9ee7..075203f1bbac4d4f6037f35e7488988cdce9060c 100644

--- a/runtime/observatory/lib/src/models/repositories/sample_profile.dart

+++ b/runtime/observatory/lib/src/models/repositories/sample_profile.dart

@@ -42,11 +42,13 @@ abstract class SampleProfileLoadingProgress {

}

abstract class ClassSampleProfileRepository {

- Stream<SampleProfileLoadingProgressEvent> get(ClassRef cls,

- SampleProfileTag tag, {bool clear: false});

+ Stream<SampleProfileLoadingProgressEvent> get(IsolateRef isolate,

+ ClassRef cls, SampleProfileTag tag);

+ Future enable(IsolateRef isolate, ClassRef cls);

+ Future disable(IsolateRef isolate, ClassRef cls);

}

abstract class IsolateSampleProfileRepository {

- Stream<SampleProfileLoadingProgressEvent> get(IsolateRef cls,

+ Stream<SampleProfileLoadingProgressEvent> get(IsolateRef isolate,

SampleProfileTag tag, {bool clear: false, bool forceFetch: false});

}