General comment cleaning / refactoring for Mac Installer

General comment cleaning / refactoring for Mac Installer

Committed: https://crrev.com/89d2bae184a37d73cb06e78ad79403d6b1fe403c
Cr-Commit-Position: refs/heads/master@{#415640}

[Anna Zeng, 2016-08-31 14:01:33]

Description was changed from

==========
General comment cleaning / refactoring for Mac Installer

BUG=
==========

to

==========
General comment cleaning / refactoring for Mac Installer
==========

[Anna Zeng, 2016-08-31 14:01:33]

zengster@google.com changed reviewers:
+ ellyjones@chromium.org, ivanhernandez@google.com, mark@chromium.org,
sdy@chromium.org

[Elly Fong-Jones, 2016-08-31 14:25:55]

lgtm :)

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/Ap...
File chrome/installer/mac/app/AppDelegate.mm (left):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/Ap...
chrome/installer/mac/app/AppDelegate.mm:59: return preventTermination_ ?
NSTerminateCancel : NSTerminateNow;
you can use a ternary for this :)

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/In...
File chrome/installer/mac/app/InstallerWindowController.m (right):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/In...
chrome/installer/mac/app/InstallerWindowController.m:116: //
downloadProgressDescription_.stringValue = @"";
if it's a bug fix, why is it commented out?

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/co...
File chrome/installer/mac/app/copy_to_disk.sh (right):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/co...
chrome/installer/mac/app/copy_to_disk.sh:29: # 'l': copy symlinks as symlinks
nice documentation :D

[Anna Zeng, 2016-08-31 14:31:18]

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/Ap...
File chrome/installer/mac/app/AppDelegate.mm (left):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/Ap...
chrome/installer/mac/app/AppDelegate.mm:59: return preventTermination_ ?
NSTerminateCancel : NSTerminateNow;
On 2016/08/31 14:25:55, Elly Jones wrote:
> you can use a ternary for this :)

Done.

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/In...
File chrome/installer/mac/app/InstallerWindowController.m (right):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/In...
chrome/installer/mac/app/InstallerWindowController.m:116: //
downloadProgressDescription_.stringValue = @"";
On 2016/08/31 14:25:55, Elly Jones wrote:
> if it's a bug fix, why is it commented out?

Uncommented!

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/co...
File chrome/installer/mac/app/copy_to_disk.sh (right):

https://codereview.chromium.org/2293923005/diff/1/chrome/installer/mac/app/co...
chrome/installer/mac/app/copy_to_disk.sh:29: # 'l': copy symlinks as symlinks
On 2016/08/31 14:25:55, Elly Jones wrote:
> nice documentation :D

Aww, thank you! I'm glad you liked it.

[Anna Zeng, 2016-08-31 14:31:23]

The CQ bit was checked by zengster@google.com

[Anna Zeng, 2016-08-31 14:31:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2293923005/#ps20001
(title: "LGTM fixes")

[Anna Zeng, 2016-08-31 14:31:43]

The CQ bit was unchecked by zengster@google.com

[Anna Zeng, 2016-08-31 14:55:53]

The CQ bit was checked by zengster@google.com

[Anna Zeng, 2016-08-31 14:55:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
ellyjones@chromium.org
Link to the patchset: https://codereview.chromium.org/2293923005/#ps40001
(title: "Ivan fixes")

[commit-bot: I haz the power, 2016-08-31 14:56:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-31 15:36:49]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-31 15:38:21]

Description was changed from

==========
General comment cleaning / refactoring for Mac Installer
==========

to

==========
General comment cleaning / refactoring for Mac Installer

Committed: https://crrev.com/89d2bae184a37d73cb06e78ad79403d6b1fe403c
Cr-Commit-Position: refs/heads/master@{#415640}
==========

[commit-bot: I haz the power, 2016-08-31 15:38:21]

Patchset 3 (id:??) landed as
https://crrev.com/89d2bae184a37d73cb06e78ad79403d6b1fe403c
Cr-Commit-Position: refs/heads/master@{#415640}

[Sidney San Martín, 2016-08-31 21:20:16]

Belated LTGM % comment.

https://codereview.chromium.org/2293923005/diff/40001/chrome/installer/mac/ap...
File chrome/installer/mac/app/AppDelegate.mm (right):

https://codereview.chromium.org/2293923005/diff/40001/chrome/installer/mac/ap...
chrome/installer/mac/app/AppDelegate.mm:68: // tear-down steps. If the user
force-quits the application, the below delegate
Force quit (cmd+option+esc) just kills the process, and you won't get any
callbacks for that. I'd just go with "If the user quits the application…"

https://codereview.chromium.org/2293923005/diff/40001/chrome/installer/mac/ap...
File chrome/installer/mac/app/copy_to_disk.sh (right):

https://codereview.chromium.org/2293923005/diff/40001/chrome/installer/mac/ap...
chrome/installer/mac/app/copy_to_disk.sh:33: # 'q': quiet mode, so rynsc will
only log to console if an error occurs
I really like these comments which describe each flag :).

[Sidney San Martín, 2016-08-31 21:20:50]

On 2016/08/31 21:20:16, Sidney San Martín wrote:
> Belated LTGM % comment.

*Belated LGTM :).