chrome/installer/mac/app/OmahaXMLRequest.m - Issue 2293923005: General comment cleaning / refactoring for Mac Installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/OmahaXMLRequest.m

Issue 2293923005: General comment cleaning / refactoring for Mac Installer (Closed)

Patch Set: Ivan fixes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/OmahaXMLRequest.m

diff --git a/chrome/installer/mac/app/OmahaXMLRequest.m b/chrome/installer/mac/app/OmahaXMLRequest.m

index b98dfe460e50e132b52c8eb1f3df9bdfb2497192..52a9bfc248f766e6d8ebd0b0f28a20e2fc3dfa60 100644

--- a/chrome/installer/mac/app/OmahaXMLRequest.m

+++ b/chrome/installer/mac/app/OmahaXMLRequest.m

@@ -23,7 +23,8 @@

// user attributes that Omaha actually looks at. The other parameters are useful

// for logging purposes but otherwise not directly used.

+ (NSXMLDocument*)createXMLRequestBody {

- // TODO: not hard-code protocol version #?

+ // TODO: This protocol version number probably shouldn't be hard-coded. Check

+ // with borisv@ regarding changing protocol verions.

NSString* protocol = @"3.0";

NSString* platform = @"mac";