Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3493)

Unified Diff: chrome/installer/mac/app/AuthorizedInstall.m

Issue 2293923005: General comment cleaning / refactoring for Mac Installer (Closed)
Patch Set: Ivan fixes Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/mac/app/AuthorizedInstall.m
diff --git a/chrome/installer/mac/app/AuthorizedInstall.m b/chrome/installer/mac/app/AuthorizedInstall.m
index 07dde8a3ed86185d0311e1d93f2c2b257555a67e..67929bed7bdef3c83c4ddd3b33c059b1dc86a653 100644
--- a/chrome/installer/mac/app/AuthorizedInstall.m
+++ b/chrome/installer/mac/app/AuthorizedInstall.m
@@ -11,7 +11,7 @@
@end
@implementation AuthorizedInstall
-// Does the setup needed to authorize a tool to run as admin.
+// Does the setup needed to authorize a subprocess to run as root.
- (OSStatus)setUpAuthorization:(AuthorizationRef*)authRef {
OSStatus status = AuthorizationCreate(NULL, kAuthorizationEmptyEnvironment,
kAuthorizationFlagDefaults, authRef);
@@ -82,10 +82,6 @@
}
}
-// Attempts to gain authorization to run installation tool with elevated
-// permissions.
-// Then starts the tool with the appropiate paths for the tools elevation
-// status.
- (BOOL)loadInstallationTool {
AuthorizationRef authRef = NULL;
OSStatus status = [self setUpAuthorization:&authRef];
@@ -117,11 +113,6 @@
return true;
}
-- (NSString*)startInstall:(NSString*)appBundlePath {
- [self sendMessageToTool:appBundlePath];
- return destinationAppBundlePath_;
-}
-
// Sends a message to the tool's stdin. The tool is using 'read' to wait for
// input. 'read' adds to its buffer until it receives a newline to continue so
// append '\n' to the message to end the read.
@@ -130,4 +121,9 @@
dataUsingEncoding:NSUTF8StringEncoding]];
}
+- (NSString*)startInstall:(NSString*)appBundlePath {
+ [self sendMessageToTool:appBundlePath];
+ return destinationAppBundlePath_;
+}
+
@end

Powered by Google App Engine
This is Rietveld 408576698