Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(889)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 229373006: Support optional, non-defaulted constructor arguments. (Closed)

Created:
6 years, 8 months ago by sof
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Support optional, non-defaulted constructor arguments. Extend the binding code generator to emit correct code for constructors having optional, but with no default, arguments. R=nbarth, haraken BUG=360546 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171251

Patch Set 1 #

Patch Set 2 : Code adjustments #

Total comments: 12

Patch Set 3 : Formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -50 lines) Patch
M Source/bindings/scripts/v8_interface.py View 1 4 chunks +10 lines, -4 lines 0 comments Download
M Source/bindings/scripts/v8_methods.py View 2 chunks +10 lines, -3 lines 0 comments Download
M Source/bindings/scripts/v8_utilities.py View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/templates/methods.cpp View 1 2 4 chunks +28 lines, -21 lines 0 comments Download
M Source/bindings/tests/idls/TestInterfaceConstructor2.idl View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl View 1 1 chunk +2 lines, -1 line 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 1 2 2 chunks +10 lines, -2 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 1 chunk +6 lines, -5 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 1 2 chunks +16 lines, -7 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 2 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
sof
6 years, 8 months ago (2014-04-09 09:39:37 UTC) #1
haraken
LGTM, but nbarth@ should take another look.
6 years, 8 months ago (2014-04-09 12:11:15 UTC) #2
Nils Barth (inactive)
Thanks for revisions! LGTM with 3 typos. https://codereview.chromium.org/229373006/diff/20001/Source/bindings/templates/methods.cpp File Source/bindings/templates/methods.cpp (right): https://codereview.chromium.org/229373006/diff/20001/Source/bindings/templates/methods.cpp#newcode399 Source/bindings/templates/methods.cpp:399: {{generate_constructor_wrapper(constructor)| indent}} ...
6 years, 8 months ago (2014-04-10 01:01:22 UTC) #3
Nils Barth (inactive)
(A few linebreak nits.) https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py File Source/bindings/scripts/v8_utilities.py (right): https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py#newcode116 Source/bindings/scripts/v8_utilities.py:116: if definition.is_static or definition.name in ...
6 years, 8 months ago (2014-04-10 01:53:25 UTC) #4
sof
https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py File Source/bindings/scripts/v8_utilities.py (right): https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py#newcode116 Source/bindings/scripts/v8_utilities.py:116: if definition.is_static or definition.name in ('Constructor', 'NamedConstructor'): On 2014/04/10 ...
6 years, 8 months ago (2014-04-10 06:16:40 UTC) #5
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-10 06:23:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/229373006/40001
6 years, 8 months ago (2014-04-10 06:23:19 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 06:46:17 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-10 06:46:17 UTC) #9
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-10 06:47:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/229373006/40001
6 years, 8 months ago (2014-04-10 06:47:16 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 06:49:01 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-10 06:49:01 UTC) #13
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-10 07:19:01 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/229373006/40001
6 years, 8 months ago (2014-04-10 07:19:04 UTC) #15
Nils Barth (inactive)
(Minor replies.) https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py File Source/bindings/scripts/v8_utilities.py (right): https://codereview.chromium.org/229373006/diff/20001/Source/bindings/scripts/v8_utilities.py#newcode116 Source/bindings/scripts/v8_utilities.py:116: if definition.is_static or definition.name in ('Constructor', 'NamedConstructor'): ...
6 years, 8 months ago (2014-04-10 07:34:06 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 08:25:49 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on linux_blink_dbg
6 years, 8 months ago (2014-04-10 08:25:50 UTC) #18
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 8 months ago (2014-04-10 08:26:53 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/229373006/40001
6 years, 8 months ago (2014-04-10 08:26:54 UTC) #20
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 09:37:31 UTC) #21
Message was sent while issue was closed. 
Change committed as 171251

Powered by Google App Engine
This is Rietveld 408576698