Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl - Issue 229373006: Support optional, non-defaulted constructor arguments.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

Issue 229373006: Support optional, non-defaulted constructor arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Formatting Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/idls/TestInterfaceConstructor2.idl ('k') | Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

diff --git a/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl b/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

index f346a7469b7c683d9be58b2c43fbd9ca8f0369b9..3e89555cdfe840be62f4eef5ca8ef9e5c5f1733d 100644

--- a/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

+++ b/Source/bindings/tests/idls/TestInterfaceNamedConstructor.idl

@@ -33,7 +33,8 @@

[Default=Undefined] optional boolean defaultUndefinedOptionalBooleanArg,

[Default=Undefined] optional long defaultUndefinedOptionalLongArg,

[Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg,

- [Default=NullString] optional DOMString defaultNullStringOptionalstringArg),

+ [Default=NullString] optional DOMString defaultNullStringOptionalstringArg,

+ optional DOMString optionalStringArg),

RaisesException=Constructor,

] interface TestInterfaceNamedConstructor {

// An attribute of type {interface_name}ConstructorConstructor is generated