Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(238)

Side by Side Diff: Source/bindings/tests/idls/TestInterfaceConstructor2.idl

Issue 229373006: Support optional, non-defaulted constructor arguments. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Code adjustments Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 24 matching lines...) Expand all
35 // 35 //
36 // Also includes some [Default] arguments (instead of in 36 // Also includes some [Default] arguments (instead of in
37 // TestInterfaceConstructor.idl), otherwise overload resolution check string is 37 // TestInterfaceConstructor.idl), otherwise overload resolution check string is
38 // extremely long and triggers a lint warning (line length). 38 // extremely long and triggers a lint warning (line length).
39 [ 39 [
40 Constructor(DOMString stringArg), 40 Constructor(DOMString stringArg),
41 Constructor( 41 Constructor(
42 TestInterfaceEmpty testInterfaceEmptyArg, 42 TestInterfaceEmpty testInterfaceEmptyArg,
43 long longArg, 43 long longArg,
44 [Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg , 44 [Default=Undefined] optional DOMString defaultUndefinedOptionalStringArg ,
45 [Default=NullString] optional DOMString defaultNullStringOptionalStringA rg, 45 [Default=Undefined] optional Dictionary defaultUndefinedOptionalDictiona ryArg,
Nils Barth (inactive) 2014/04/10 01:01:23 ? Could you keep the [Default=NullString] argument
sof 2014/04/10 06:16:40 Done.
46 [Default=Undefined] optional Dictionary defaultUndefinedOptionalDictiona ryArg), 46 optional DOMString optionalStringArg),
47 ] interface TestInterfaceConstructor2 { 47 ] interface TestInterfaceConstructor2 {
48 }; 48 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698