Issue 22929021: Converge file_util::GetFileInfo and base::GetPlaformFileInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22929021: Converge file_util::GetFileInfo and base::GetPlaformFileInfo. (Closed)

Created:
7 years, 4 months ago by gavinp

Modified:
3 years, 7 months ago

Reviewers:
pasko, darin (slow to review)

CC:
chromium-reviews, erikwright+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Converge file_util::GetFileInfo and base::GetPlaformFileInfo. Previously file_util::GetFileInfo didn't detect symlinks, now fixed, and the high resolution time information in base::GetPlatformFileInfo was unnecessarily verbose. Now fixed. R=darin BUG=None

Patch Set 1 #

Patch Set 2 : win some #

Patch Set 3 : nacl? #

Total comments: 1

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -60 lines)			Patch
M	base/file_util_posix.cc	View		1 chunk	+18 lines, -12 lines	0 comments	Download
M	base/file_util_unittest.cc	View		2 chunks	+9 lines, -1 line	0 comments	Download
M	base/file_util_win.cc	View	1	2 chunks	+11 lines, -6 lines	0 comments	Download
M	base/platform_file_posix.cc	View	1 2	2 chunks	+11 lines, -41 lines	1 comment	Download
M	base/platform_file_win.cc	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

gavinp

Darin, PTAL. I am sure these should be unified even more; however this at least ...

7 years, 4 months ago (2013-08-21 14:19:31 UTC) #1

pasko

7 years, 4 months ago (2013-08-21 14:40:57 UTC) #2

fly by note

https://codereview.chromium.org/22929021/diff/14001/base/platform_file_posix.cc
File base/platform_file_posix.cc (left):

https://codereview.chromium.org/22929021/diff/14001/base/platform_file_posix....
base/platform_file_posix.cc:32: #if defined(OS_BSD) || defined(OS_MACOSX) ||
defined(OS_NACL)
nacl has largefile with so this should be OK, thanks

Expand Messages | Collapse Messages