Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3128)

Unified Diff: base/file_util_win.cc

Issue 22929021: Converge file_util::GetFileInfo and base::GetPlaformFileInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nacl? Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_util_win.cc
diff --git a/base/file_util_win.cc b/base/file_util_win.cc
index 39317a3a932777a3a10f635ba9024f7a92a4746e..b35b3fc1c5f291b6716529f5151f935650ded9d3 100644
--- a/base/file_util_win.cc
+++ b/base/file_util_win.cc
@@ -412,8 +412,10 @@ bool IsLink(const FilePath& file_path) {
return false;
}
-bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* results) {
+bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* info) {
base::ThreadRestrictions::AssertIOAllowed();
+ if (!info)
+ return false;
WIN32_FILE_ATTRIBUTE_DATA attr;
if (!GetFileAttributesEx(file_path.value().c_str(),
@@ -424,14 +426,17 @@ bool GetFileInfo(const FilePath& file_path, base::PlatformFileInfo* results) {
ULARGE_INTEGER size;
size.HighPart = attr.nFileSizeHigh;
size.LowPart = attr.nFileSizeLow;
- results->size = size.QuadPart;
+ info->size = size.QuadPart;
- results->is_directory =
+ info->is_directory =
(attr.dwFileAttributes & FILE_ATTRIBUTE_DIRECTORY) != 0;
- results->last_modified = base::Time::FromFileTime(attr.ftLastWriteTime);
- results->last_accessed = base::Time::FromFileTime(attr.ftLastAccessTime);
- results->creation_time = base::Time::FromFileTime(attr.ftCreationTime);
+ // TODO(gavinp): What about reparse points?
+ info->is_symbolic_link = false; // Windows doesn't have symbolic links.
+
+ info->last_modified = base::Time::FromFileTime(attr.ftLastWriteTime);
+ info->last_accessed = base::Time::FromFileTime(attr.ftLastAccessTime);
+ info->creation_time = base::Time::FromFileTime(attr.ftCreationTime);
return true;
}

Powered by Google App Engine
This is Rietveld 408576698