Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3887)

Unified Diff: base/file_util_unittest.cc

Issue 22929021: Converge file_util::GetFileInfo and base::GetPlaformFileInfo. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: nacl? Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/file_util_unittest.cc
diff --git a/base/file_util_unittest.cc b/base/file_util_unittest.cc
index 787b6d50ba7df6f1472a59371fee4070c13c9da4..54c8accd4ae10ae1dd93fe631aad4f64ed1e9e7c 100644
--- a/base/file_util_unittest.cc
+++ b/base/file_util_unittest.cc
@@ -593,7 +593,7 @@ TEST_F(FileUtilTest, DevicePathToDriveLetter) {
}
TEST_F(FileUtilTest, GetPlatformFileInfoForDirectory) {
- FilePath empty_dir = temp_dir_.path().Append(FPL("gpfi_test"));
+ FilePath empty_dir = temp_dir_.path().Append(FPL("gpfifd_test"));
ASSERT_TRUE(file_util::CreateDirectory(empty_dir));
base::win::ScopedHandle dir(
::CreateFile(empty_dir.value().c_str(),
@@ -678,6 +678,14 @@ TEST_F(FileUtilTest, CreateAndReadSymlinks) {
std::wstring contents = ReadTextFile(link_from);
EXPECT_EQ(bogus_content, contents);
+ base::PlatformFileInfo link_to_info;
+ ASSERT_TRUE(file_util::GetFileInfo(link_to, &link_to_info));
+ EXPECT_FALSE(link_to_info.is_symbolic_link);
+
+ base::PlatformFileInfo link_from_info;
+ ASSERT_TRUE(file_util::GetFileInfo(link_from, &link_from_info));
+ EXPECT_TRUE(link_from_info.is_symbolic_link);
+
FilePath result;
ASSERT_TRUE(file_util::ReadSymbolicLink(link_from, &result));
EXPECT_EQ(link_to.value(), result.value());
« no previous file with comments | « base/file_util_posix.cc ('k') | base/file_util_win.cc » ('j') | base/platform_file_posix.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698