Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2292843002: Remove WTFLogAlways() usages from core/{dom,editing}/. (Closed)

Created:
4 years, 3 months ago by tkent
Modified:
4 years, 3 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, jchaffraix+rendering, kenneth.christiansen, kinuko+watch, leviw+renderwatch, loading-reviews+parser_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove WTFLogAlways() usages from core/{dom,editing}/. Use LOG(INFO) instead. For single-line strings like showNode(): [n:n:n/n:n:INFO:Node.cpp(n)] fooBar For multiple-line strings like showTree(): [n:n:n/n:n:INFO:Node.cpp(n)] BODY #text "\n" ... * This CL removes Node::showNode(). It was a simple wrapper for operator<< for Node. * As for HTMLFormattingElementList and SnapCoordinator, just call LOG(INFO) multiple times because they don't show tree structures. BUG=638849 Committed: https://crrev.com/1f0db7b935974863cb125198b6f1e93dfb9b8285 Cr-Commit-Position: refs/heads/master@{#415262}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -54 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 4 chunks +13 lines, -24 lines 0 comments Download
M third_party/WebKit/Source/core/editing/Position.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/Position.cpp View 3 chunks +16 lines, -13 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 chunk +6 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLElementStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/scrolling/SnapCoordinator.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
tkent
yosin@, would you review this please?
4 years, 3 months ago (2016-08-30 08:03:05 UTC) #5
yosin_UTC9
lgtm
4 years, 3 months ago (2016-08-30 08:17:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292843002/1
4 years, 3 months ago (2016-08-30 09:57:46 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 10:01:34 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 10:02:42 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1f0db7b935974863cb125198b6f1e93dfb9b8285
Cr-Commit-Position: refs/heads/master@{#415262}

Powered by Google App Engine
This is Rietveld 408576698