Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Unified Diff: third_party/WebKit/Source/core/editing/Position.cpp

Issue 2292843002: Remove WTFLogAlways() usages from core/{dom,editing}/. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/Position.cpp
diff --git a/third_party/WebKit/Source/core/editing/Position.cpp b/third_party/WebKit/Source/core/editing/Position.cpp
index 3cb68f58e0dffeead510713b5ce7495aaaedd64f..1488cbf64b21a57d6875290c4c7e3a5432e14450 100644
--- a/third_party/WebKit/Source/core/editing/Position.cpp
+++ b/third_party/WebKit/Source/core/editing/Position.cpp
@@ -603,26 +603,29 @@ Position toPositionInDOMTree(const PositionInFlatTree& position)
#ifndef NDEBUG
template <typename Strategy>
-void PositionTemplate<Strategy>::showAnchorTypeAndOffset() const
+String PositionTemplate<Strategy>::toAnchorTypeAndOffsetString() const
{
+ StringBuilder builder;
switch (anchorType()) {
case PositionAnchorType::OffsetInAnchor:
- fputs("offset", stderr);
+ builder.append("offset");
break;
case PositionAnchorType::BeforeChildren:
- fputs("beforeChildren", stderr);
+ builder.append("beforeChildren");
break;
case PositionAnchorType::AfterChildren:
- fputs("afterChildren", stderr);
+ builder.append("afterChildren");
break;
case PositionAnchorType::BeforeAnchor:
- fputs("before", stderr);
+ builder.append("before");
break;
case PositionAnchorType::AfterAnchor:
- fputs("after", stderr);
+ builder.append("after");
break;
}
- fprintf(stderr, ", offset:%d\n", m_offset);
+ builder.append(", offset:");
+ builder.append(m_offset);
+ return builder.toString();
}
template <typename Strategy>
@@ -630,9 +633,9 @@ void PositionTemplate<Strategy>::showTreeForThis() const
{
if (!anchorNode())
return;
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", anchorNode()->toTreeStringForThis().utf8().data());
- showAnchorTypeAndOffset();
+ LOG(INFO) << "\n"
+ << anchorNode()->toTreeStringForThis().utf8().data()
+ << toAnchorTypeAndOffsetString().utf8().data();
}
template <typename Strategy>
@@ -640,9 +643,9 @@ void PositionTemplate<Strategy>::showTreeForThisInFlatTree() const
{
if (!anchorNode())
return;
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", anchorNode()->toFlatTreeStringForThis().utf8().data());
- showAnchorTypeAndOffset();
+ LOG(INFO) << "\n"
+ << anchorNode()->toFlatTreeStringForThis().utf8().data()
+ << toAnchorTypeAndOffsetString().utf8().data();
}
#endif
« no previous file with comments | « third_party/WebKit/Source/core/editing/Position.h ('k') | third_party/WebKit/Source/core/editing/VisibleSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698