Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(326)

Unified Diff: third_party/WebKit/Source/core/dom/Node.cpp

Issue 2292843002: Remove WTFLogAlways() usages from core/{dom,editing}/. (Closed)
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/editing/Position.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/Node.cpp
diff --git a/third_party/WebKit/Source/core/dom/Node.cpp b/third_party/WebKit/Source/core/dom/Node.cpp
index a1b6cb6a1a4ae331af98e9d99226d137f7914721..22faafa319c91c6627168bf0935e0b5d5de4dbf3 100644
--- a/third_party/WebKit/Source/core/dom/Node.cpp
+++ b/third_party/WebKit/Source/core/dom/Node.cpp
@@ -1500,7 +1500,6 @@ static void dumpAttributeDesc(const Node& node, const QualifiedName& name, std::
ostream << ' ' << name.toString().utf8().data() << '=' << value;
}
-// |std::ostream| version of |Node::showNode|
std::ostream& operator<<(std::ostream& ostream, const Node& node)
{
if (node.getNodeType() == Node::kProcessingInstructionNode)
@@ -1545,16 +1544,6 @@ String Node::toString() const
return String(stream.str().c_str());
}
-void Node::showNode(const char* prefix) const
-{
- std::stringstream stream;
- if (prefix)
- stream << prefix;
- stream << *this << "\n";
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", stream.str().c_str());
-}
-
String Node::toTreeStringForThis() const
{
return toMarkedTreeString(this, "*");
@@ -1735,8 +1724,7 @@ void Node::showTreeForThisAcrossFrame() const
rootNode = parentOrShadowHostOrFrameOwner(rootNode);
std::stringstream stream;
printSubTreeAcrossFrame(rootNode, this, "", stream);
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", stream.str().c_str());
+ LOG(INFO) << "\n" << stream.str();
}
#endif
@@ -2396,27 +2384,28 @@ v8::Local<v8::Object> Node::associateWithWrapper(v8::Isolate* isolate, const Wra
void showNode(const blink::Node* node)
{
if (node)
- node->showNode("");
+ LOG(INFO) << *node;
else
- fprintf(stderr, "Cannot showNode for (nil)\n");
+ LOG(INFO) << "Cannot showNode for <null>";
}
void showTree(const blink::Node* node)
{
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", node ? node->toTreeStringForThis().utf8().data() : "Cannot showTree for <null>");
+ if (node)
+ LOG(INFO) << "\n" << node->toTreeStringForThis().utf8().data();
+ else
+ LOG(INFO) << "Cannot showTree for <null>";
}
void showNodePath(const blink::Node* node)
{
- std::stringstream stream;
- if (node)
+ if (node) {
+ std::stringstream stream;
node->printNodePathTo(stream);
- else
- stream << "Cannot showNodePath for <null>";
- stream << "\n";
- // TODO(tkent): Replace WTFLogAlways with something else.
- WTFLogAlways("%s", stream.str().c_str());
+ LOG(INFO) << stream.str();
+ } else {
+ LOG(INFO) << "Cannot showNodePath for <null>";
+ }
}
#endif
« no previous file with comments | « third_party/WebKit/Source/core/dom/Node.h ('k') | third_party/WebKit/Source/core/editing/Position.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698