Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2292813002: Revert "[Android]Use zh instead of zh-rTW as output folder of zh_TW translation" (Closed)

Created:
4 years, 3 months ago by Ian Wen
Modified:
4 years, 3 months ago
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2840
Project:
chromium
Visibility:
Public.

Description

Revert "[Android]Use zh instead of zh-rTW as output folder of zh_TW translation" This reverts commit 21571ae1ee47d614541f814bd98dfbd71f561dbc, which was committed in M52. Reason for revert: in android N, locale is defined in finer granularity, and simply falling back to zh will no longer work. BUG=641852 Previously reviewed in https://codereview.chromium.org/1931093002 R=twellington@chromium.org TBR=boliu@chromium.org, caitkp@chromium.org, dtrainor@chromium.org, grt@chromium.org, joedow@chromium.org, yfriedman@chromium.org Review URL: https://codereview.chromium.org/2280143002 . Cr-Commit-Position: refs/heads/master@{#415045} (cherry picked from commit e5a4384de1d67657590646b306c6e66746f1174b) Committed: https://chromium.googlesource.com/chromium/src/+/aae95a370846313b440c3146fdde6a5f67a6db43

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -20 lines) Patch
M android_webview/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/strings/android_webview_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/java/strings/android_blimp_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_locale_settings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/strings/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/remoting_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ian Wen
4 years, 3 months ago (2016-08-30 03:28:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
aae95a370846313b440c3146fdde6a5f67a6db43.

Powered by Google App Engine
This is Rietveld 408576698