Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Issue 2280143002: Revert "[Android]Use zh instead of zh-rTW as output folder of zh_TW translation" (Closed)

Created:
4 years, 3 months ago by Ian Wen
Modified:
4 years, 3 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, chromoting-reviews_chromium.org, jam, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, lethalantidote+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, android-webview-reviews_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "[Android]Use zh instead of zh-rTW as output folder of zh_TW translation" This reverts commit 21571ae1ee47d614541f814bd98dfbd71f561dbc, which was committed in M52. Reason for revert: in android N, locale is defined in finer granularity, and simply falling back to zh will no longer work. BUG=641852 Previously reviewed in https://codereview.chromium.org/1931093002 R=twellington@chromium.org TBR=boliu@chromium.org, caitkp@chromium.org, dtrainor@chromium.org, grt@chromium.org, joedow@chromium.org, yfriedman@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/e5a4384de1d67657590646b306c6e66746f1174b

Patch Set 1 #

Patch Set 2 : fix lint #

Total comments: 10

Patch Set 3 : comments #

Patch Set 4 : more accurate comments #

Patch Set 5 : Revert change in AsyncInitializationActivity #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -21 lines) Patch
M android_webview/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/strings/android_webview_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/java/strings/android_blimp_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M build/android/lint/suppressions.xml View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/app/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M components/components_locale_settings.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/strings/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_locales.gni View 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/remoting_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 32 (18 generated)
Ian Wen
PTAL
4 years, 3 months ago (2016-08-26 19:03:52 UTC) #2
Theresa
lgtm
4 years, 3 months ago (2016-08-26 20:54:22 UTC) #3
Ian Wen
TBR the same people who have reviewed the original CL.
4 years, 3 months ago (2016-08-26 21:11:48 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2280143002/1
4 years, 3 months ago (2016-08-26 21:13:09 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/119470)
4 years, 3 months ago (2016-08-26 21:45:08 UTC) #13
Theresa
https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode77 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:77: @TargetApi(24) This needs to get updated to JellyBean_MR1 https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode79 ...
4 years, 3 months ago (2016-08-29 20:44:23 UTC) #15
Ian Wen
https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode77 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:77: @TargetApi(24) On 2016/08/29 20:44:23, Theresa Wellington wrote: > This ...
4 years, 3 months ago (2016-08-29 21:03:47 UTC) #16
jungshik at Google
https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode96 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:96: // Before Android N, zh_HK is not well supported. ...
4 years, 3 months ago (2016-08-29 21:19:42 UTC) #20
Ian Wen
https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java File chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java (right): https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java#newcode96 chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java:96: // Before Android N, zh_HK is not well supported. ...
4 years, 3 months ago (2016-08-29 21:34:03 UTC) #21
jungshik at Google
Could you also update the CL summary and description? This CL does more than reverting ...
4 years, 3 months ago (2016-08-29 21:37:27 UTC) #22
jungshik at Google
On 2016/08/29 21:34:03, Ian Wen wrote: > https://codereview.chromium.org/2280143002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java > File > chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java > (right): > ...
4 years, 3 months ago (2016-08-29 21:41:51 UTC) #23
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/e5a4384de1d67657590646b306c6e66746f1174b Cr-Commit-Position: refs/heads/master@{#415045}
4 years, 3 months ago (2016-08-30 02:45:27 UTC) #29
Ian Wen
Committed patchset #5 (id:80001) manually as e5a4384de1d67657590646b306c6e66746f1174b (presubmit successful).
4 years, 3 months ago (2016-08-30 02:46:31 UTC) #31
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 03:34:03 UTC) #32
Message was sent while issue was closed.
Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

Powered by Google App Engine
This is Rietveld 408576698