Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1931093002: [Android]Use zh instead of zh-rTW as output folder of zh_TW translation (Closed)

Created:
4 years, 7 months ago by Ian Wen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, chromoting-reviews_chromium.org, jam, nyquist+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, android-webview-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android]Use zh instead of zh-rTW as output folder of zh_TW translation Android does not support zh-HK, yet many vendors still ship devices with this locale. By default Android will fall back to English when it sees zh-HK. This CL changes the output folder of our traditional Chinese folder from zh-rTW to zh so that zh_HK users will fall back to traditional Chinese. This CL does not affect simplified Chinese. It will affect other unsupported Chinese locales such as zh_sg (if any). BUG=555101 Committed: https://crrev.com/21571ae1ee47d614541f814bd98dfbd71f561dbc Cr-Commit-Position: refs/heads/master@{#391105}

Patch Set 1 #

Total comments: 1

Patch Set 2 : added space before the end of a comment #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M android_webview/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M android_webview/java/strings/android_webview_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/app/android/java/strings/android_blimp_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/app/BUILD.gn View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/app/generated_resources.grd View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/components_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M components/strings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M content/public/android/java/strings/android_content_strings.grd View 1 chunk +1 line, -1 line 0 comments Download
M remoting/remoting_locales.gni View 1 2 1 chunk +1 line, -1 line 0 comments Download
M remoting/resources/remoting_strings.grd View 1 1 chunk +1 line, -1 line 0 comments Download
M ui/android/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M ui/android/java/strings/android_ui_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 29 (12 generated)
Ian Wen
Dear reviewers, PTAL at this CL about translation. Thank you!
4 years, 7 months ago (2016-04-28 22:23:11 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931093002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931093002/1
4 years, 7 months ago (2016-04-28 22:23:43 UTC) #4
boliu
lgtm sounds fine given CL description, wish there is a single place to put a ...
4 years, 7 months ago (2016-04-28 22:31:12 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-04-28 23:34:00 UTC) #7
nyquist
lgtm
4 years, 7 months ago (2016-04-29 00:22:16 UTC) #8
Ted C
lgtm
4 years, 7 months ago (2016-04-29 00:31:59 UTC) #9
Ian Wen
Dear owners of app/chromoting/components, could you PTAL at this CL? Thanks!
4 years, 7 months ago (2016-04-29 00:45:17 UTC) #11
Lei Zhang
On 2016/04/29 00:45:17, Ian Wen wrote: > Dear owners of app/chromoting/components, could you PTAL at ...
4 years, 7 months ago (2016-04-29 00:48:58 UTC) #12
Cait (Slow)
components lgtm
4 years, 7 months ago (2016-04-29 22:04:30 UTC) #13
joedow
remoting lgtm
4 years, 7 months ago (2016-04-29 22:10:53 UTC) #15
Ian Wen
Hello grt@: would you mind taking a look at this CL? Thanks!
4 years, 7 months ago (2016-04-29 22:53:24 UTC) #17
grt (UTC plus 2)
lgtm https://codereview.chromium.org/1931093002/diff/1/chrome/android/java/strings/android_chrome_strings.grd File chrome/android/java/strings/android_chrome_strings.grd (right): https://codereview.chromium.org/1931093002/diff/1/chrome/android/java/strings/android_chrome_strings.grd#newcode78 chrome/android/java/strings/android_chrome_strings.grd:78: <!-- Use zh instead of zh-rTW so that ...
4 years, 7 months ago (2016-04-30 11:09:32 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931093002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931093002/20001
4 years, 7 months ago (2016-05-02 20:04:36 UTC) #21
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_dbg/builds/60065)
4 years, 7 months ago (2016-05-02 20:59:54 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1931093002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1931093002/40001
4 years, 7 months ago (2016-05-02 22:18:44 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 7 months ago (2016-05-02 23:49:21 UTC) #27
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:51:05 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/21571ae1ee47d614541f814bd98dfbd71f561dbc
Cr-Commit-Position: refs/heads/master@{#391105}

Powered by Google App Engine
This is Rietveld 408576698