Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2292573002: [inspector] Initial import of v8_inspector. (Closed)

Created:
4 years, 3 months ago by dgozman
Modified:
4 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[inspector] Initial import of v8_inspector. Attempt #2, formatted and disabled lint for src/inspector. BUG=chromium:635948 NOPRESUBMIT=true (for grammar check in license code) Committed: https://crrev.com/130d0486c08b953b4ec35abc28dc916807f2cf5f Cr-Commit-Position: refs/heads/master@{#39107}

Patch Set 1 #

Patch Set 2 : guards, includes #

Patch Set 3 : copyrights #

Patch Set 4 : format the code, disable cpplint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14648 lines, -321 lines) Patch
M AUTHORS View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
A src/inspector/Allocator.h View 1 2 3 1 chunk +38 lines, -0 lines 0 comments Download
A src/inspector/Atomics.h View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A src/inspector/DebuggerScript.js View 1 chunk +711 lines, -0 lines 0 comments Download
A src/inspector/InjectedScript.h View 1 2 3 1 chunk +207 lines, -0 lines 0 comments Download
A src/inspector/InjectedScript.cpp View 1 2 3 1 chunk +568 lines, -0 lines 0 comments Download
A src/inspector/InjectedScriptNative.h View 1 2 3 1 chunk +45 lines, -0 lines 0 comments Download
A src/inspector/InjectedScriptNative.cpp View 1 2 3 1 chunk +90 lines, -0 lines 0 comments Download
A src/inspector/InjectedScriptSource.js View 1 chunk +1076 lines, -0 lines 0 comments Download
A src/inspector/InspectedContext.h View 1 2 3 1 chunk +64 lines, -0 lines 0 comments Download
A src/inspector/InspectedContext.cpp View 1 2 3 1 chunk +84 lines, -0 lines 0 comments Download
A src/inspector/JavaScriptCallFrame.h View 1 2 3 1 chunk +81 lines, -0 lines 0 comments Download
A src/inspector/JavaScriptCallFrame.cpp View 1 2 3 1 chunk +146 lines, -0 lines 0 comments Download
A src/inspector/ProtocolPlatform.h View 1 2 3 1 chunk +15 lines, -0 lines 0 comments Download
A src/inspector/RemoteObjectId.h View 1 2 3 1 chunk +58 lines, -0 lines 0 comments Download
A src/inspector/RemoteObjectId.cpp View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A src/inspector/ScriptBreakpoint.h View 1 2 3 1 chunk +52 lines, -0 lines 0 comments Download
A src/inspector/SearchUtil.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A src/inspector/SearchUtil.cpp View 1 2 3 1 chunk +164 lines, -0 lines 0 comments Download
A src/inspector/String16.h View 1 2 3 1 chunk +132 lines, -0 lines 0 comments Download
A src/inspector/String16.cpp View 1 2 3 1 chunk +510 lines, -0 lines 0 comments Download
A src/inspector/StringUtil.h View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A src/inspector/StringUtil.cpp View 1 2 3 1 chunk +195 lines, -0 lines 0 comments Download
A src/inspector/V8Compat.h View 1 2 3 1 chunk +33 lines, -0 lines 0 comments Download
A src/inspector/V8Console.h View 1 2 3 1 chunk +119 lines, -0 lines 0 comments Download
A src/inspector/V8Console.cpp View 1 2 3 1 chunk +908 lines, -0 lines 0 comments Download
A src/inspector/V8ConsoleAgentImpl.h View 1 2 3 1 chunk +48 lines, -0 lines 0 comments Download
A src/inspector/V8ConsoleAgentImpl.cpp View 1 2 3 1 chunk +76 lines, -0 lines 0 comments Download
A src/inspector/V8ConsoleMessage.h View 1 2 3 1 chunk +120 lines, -0 lines 0 comments Download
A src/inspector/V8ConsoleMessage.cpp View 1 2 3 1 chunk +458 lines, -0 lines 0 comments Download
A src/inspector/V8Debugger.h View 1 2 3 1 chunk +159 lines, -0 lines 0 comments Download
A src/inspector/V8Debugger.cpp View 1 2 3 1 chunk +917 lines, -0 lines 0 comments Download
A src/inspector/V8DebuggerAgentImpl.h View 1 2 3 1 chunk +224 lines, -0 lines 0 comments Download
A src/inspector/V8DebuggerAgentImpl.cpp View 1 2 3 1 chunk +1249 lines, -0 lines 0 comments Download
A src/inspector/V8DebuggerScript.h View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
A src/inspector/V8DebuggerScript.cpp View 1 2 3 1 chunk +134 lines, -0 lines 0 comments Download
A src/inspector/V8FunctionCall.h View 1 2 3 1 chunk +65 lines, -0 lines 0 comments Download
A src/inspector/V8FunctionCall.cpp View 1 2 3 1 chunk +113 lines, -0 lines 0 comments Download
A src/inspector/V8HeapProfilerAgentImpl.h View 1 2 3 1 chunk +73 lines, -0 lines 0 comments Download
A src/inspector/V8HeapProfilerAgentImpl.cpp View 1 2 3 1 chunk +424 lines, -0 lines 0 comments Download
A src/inspector/V8InjectedScriptHost.h View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A src/inspector/V8InjectedScriptHost.cpp View 1 2 3 1 chunk +210 lines, -0 lines 0 comments Download
A src/inspector/V8InspectorImpl.h View 1 2 3 1 chunk +147 lines, -0 lines 0 comments Download
A src/inspector/V8InspectorImpl.cpp View 1 2 3 1 chunk +362 lines, -0 lines 0 comments Download
A src/inspector/V8InspectorSessionImpl.h View 1 2 3 1 chunk +127 lines, -0 lines 0 comments Download
A src/inspector/V8InspectorSessionImpl.cpp View 1 2 3 1 chunk +420 lines, -0 lines 0 comments Download
A src/inspector/V8InternalValueType.h View 1 2 3 1 chunk +23 lines, -0 lines 0 comments Download
A src/inspector/V8InternalValueType.cpp View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
A src/inspector/V8ProfilerAgentImpl.h View 1 2 3 1 chunk +70 lines, -0 lines 0 comments Download
A src/inspector/V8ProfilerAgentImpl.cpp View 1 2 3 1 chunk +324 lines, -0 lines 0 comments Download
A src/inspector/V8Regex.h View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A src/inspector/V8Regex.cpp View 1 2 3 1 chunk +93 lines, -0 lines 0 comments Download
A src/inspector/V8RuntimeAgentImpl.h View 1 2 3 1 chunk +131 lines, -0 lines 0 comments Download
A src/inspector/V8RuntimeAgentImpl.cpp View 1 2 3 1 chunk +726 lines, -0 lines 0 comments Download
A src/inspector/V8SchemaAgentImpl.h View 1 2 3 1 chunk +37 lines, -0 lines 0 comments Download
A src/inspector/V8SchemaAgentImpl.cpp View 1 2 3 1 chunk +29 lines, -0 lines 0 comments Download
A src/inspector/V8StackTraceImpl.h View 1 2 3 1 chunk +98 lines, -0 lines 0 comments Download
A src/inspector/V8StackTraceImpl.cpp View 1 2 3 1 chunk +275 lines, -0 lines 0 comments Download
A src/inspector/V8ValueCopier.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A src/inspector/V8ValueCopier.cpp View 1 2 3 1 chunk +110 lines, -0 lines 0 comments Download
A src/inspector/build/rjsmin.py View 1 chunk +295 lines, -0 lines 0 comments Download
A src/inspector/build/xxd.py View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
A src/inspector/debugger_script_externs.js View 1 2 1 chunk +547 lines, -0 lines 0 comments Download
A src/inspector/injected_script_externs.js View 1 2 1 chunk +66 lines, -0 lines 0 comments Download
A src/inspector/inspector_protocol_config.json View 1 1 chunk +29 lines, -0 lines 0 comments Download
M src/inspector/js_protocol.json View 38 chunks +146 lines, -160 lines 0 comments Download
A + src/inspector/js_protocol-1.2.json View 38 chunks +146 lines, -160 lines 0 comments Download
A src/inspector/public/StringBuffer.h View 1 2 3 1 chunk +24 lines, -0 lines 0 comments Download
A src/inspector/public/StringView.h View 1 2 3 1 chunk +42 lines, -0 lines 0 comments Download
A src/inspector/public/V8ContextInfo.h View 1 2 3 1 chunk +46 lines, -0 lines 0 comments Download
A src/inspector/public/V8Inspector.h View 1 2 3 1 chunk +72 lines, -0 lines 0 comments Download
A src/inspector/public/V8InspectorClient.h View 1 2 3 1 chunk +74 lines, -0 lines 0 comments Download
A src/inspector/public/V8InspectorSession.h View 1 2 3 1 chunk +63 lines, -0 lines 0 comments Download
A src/inspector/public/V8StackTrace.h View 1 2 3 1 chunk +34 lines, -0 lines 0 comments Download
M tools/presubmit.py View 1 2 3 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 51 (37 generated)
dgozman
Hi, could you please take a look? This patch has 3 steps: - importing files; ...
4 years, 3 months ago (2016-08-30 19:30:33 UTC) #10
jochen (gone - plz use gerrit)
should there be an OWNERS file?
4 years, 3 months ago (2016-08-30 19:34:21 UTC) #11
dgozman
On 2016/08/30 19:34:21, jochen wrote: > should there be an OWNERS file? Sure, I'll add ...
4 years, 3 months ago (2016-08-30 20:24:28 UTC) #12
jochen (gone - plz use gerrit)
lgtm
4 years, 3 months ago (2016-08-31 14:27:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292573002/40001
4 years, 3 months ago (2016-08-31 20:22:53 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/22968)
4 years, 3 months ago (2016-08-31 20:27:31 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292573002/40001
4 years, 3 months ago (2016-08-31 21:28:57 UTC) #20
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-31 21:34:22 UTC) #22
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e29594ea3c5c41de0844e71f7a82c990a8da71ee Cr-Commit-Position: refs/heads/master@{#39057}
4 years, 3 months ago (2016-08-31 21:35:09 UTC) #24
Michael Achenbach
A revert of this CL (patchset #3 id:40001) has been created in https://codereview.chromium.org/2300823002/ by machenbach@chromium.org. ...
4 years, 3 months ago (2016-08-31 21:47:16 UTC) #25
dgozman
I'm submitting this once again, with cpplint disable and code reformatted.
4 years, 3 months ago (2016-09-01 20:26:01 UTC) #43
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292573002/100001
4 years, 3 months ago (2016-09-01 20:27:09 UTC) #47
commit-bot: I haz the power
Committed patchset #4 (id:100001)
4 years, 3 months ago (2016-09-01 20:27:54 UTC) #49
commit-bot: I haz the power
4 years, 3 months ago (2016-09-01 20:28:43 UTC) #51
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/130d0486c08b953b4ec35abc28dc916807f2cf5f
Cr-Commit-Position: refs/heads/master@{#39107}

Powered by Google App Engine
This is Rietveld 408576698