Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: src/v8.gyp

Issue 2292053003: [inspector] Build inspector under v8_enable_inspector build flag. (Closed)
Patch Set: owners Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« build_overrides/v8.gni ('K') | « src/inspector/public/V8StackTrace.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8.gyp
diff --git a/src/v8.gyp b/src/v8.gyp
index 4fffafd3b413fa88c4c40bbd53f89b117bd70094..27617793f4fa0a220a248a7438c1df56ec19d395 100644
--- a/src/v8.gyp
+++ b/src/v8.gyp
@@ -34,10 +34,11 @@
'warmup_script%': "",
'v8_extra_library_files%': [],
'v8_experimental_extra_library_files%': [],
+ 'v8_enable_inspector%': 0,
'mksnapshot_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mksnapshot<(EXECUTABLE_SUFFIX)',
'mkpeephole_exec': '<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)mkpeephole<(EXECUTABLE_SUFFIX)',
},
- 'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi'],
+ 'includes': ['../gypfiles/toolchain.gypi', '../gypfiles/features.gypi', 'inspector/inspector.gypi'],
'targets': [
{
'target_name': 'v8',
@@ -1729,6 +1730,30 @@
'i18n.h',
],
}],
+ ['v8_enable_inspector==1', {
+ 'sources': [
+ '<@(inspector_all_sources)'
+ ],
+ 'dependencies': [
Michael Achenbach 2016/09/05 06:40:34 Didn't see any gn equivalent of this in this CL. N
dgozman 2016/09/06 17:37:35 GN achieves this by having a v8_source_set("inspec
Michael Achenbach 2016/09/06 18:27:22 Acknowledged.
+ 'inspector/inspector.gyp:protocol_generated_sources',
+ 'inspector/inspector.gyp:inspector_injected_script',
+ 'inspector/inspector.gyp:inspector_debugger_script',
+ ],
+ # TODO(dgozman): fix these warnings and enable them.
+ 'msvs_disabled_warnings': [
+ 4267, # Truncation from size_t to int.
+ 4305, # Truncation from 'type1' to 'type2'.
+ 4324, # Struct padded due to declspec(align).
+ 4714, # Function marked forceinline not inlined.
+ 4800, # Value forced to bool.
+ 4996, # Deprecated function call.
+ ],
+ 'cflags': [
+ '-Wno-zero-length-array',
+ '-Wno-shorten-64-to-32',
+ '-Wno-deprecated-declarations',
+ ],
+ }],
['OS=="win" and v8_enable_i18n_support==1', {
'dependencies': [
'<(icu_gyp_path):icudata',
« build_overrides/v8.gni ('K') | « src/inspector/public/V8StackTrace.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698