chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient

chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient

Replace dbus::FileDescriptor with base::ScopedFD

BUG=621841
Committed: https://crrev.com/1568856ab34e9581e2a7e0cf86116d3c23d0640e
Cr-Commit-Position: refs/heads/master@{#415847}

[hashimoto, 2016-08-30 08:50:25]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[hashimoto, 2016-08-30 08:50:44]

hashimoto@chromium.org changed reviewers:
+ satorux@chromium.org, stevenjb@chromium.org

[commit-bot: I haz the power, 2016-08-30 08:50:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-30 09:50:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-30 09:50:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2016-08-30 15:45:59]

owner lgtm

https://codereview.chromium.org/2291983002/diff/1/device/usb/usb_device_linux.cc
File device/usb/usb_device_linux.cc (right):

https://codereview.chromium.org/2291983002/diff/1/device/usb/usb_device_linux...
device/usb/usb_device_linux.cc:96: }
nit: invert if and early exit, no else.

[satorux1, 2016-08-31 05:18:08]

lgtm with a request

https://codereview.chromium.org/2291983002/diff/1/chromeos/dbus/permission_br...
File chromeos/dbus/permission_broker_client.h (right):

https://codereview.chromium.org/2291983002/diff/1/chromeos/dbus/permission_br...
chromeos/dbus/permission_broker_client.h:64: // permission broker can monitor
the lifetime of the calling process.
add some comment about |lifeline_fd| like you did with the debug daemon client?

// This method duplicates |lifeline_fd| so it's OK to close the FD
// withoutwaiting for the result.

[hashimoto, 2016-08-31 07:09:24]

https://codereview.chromium.org/2291983002/diff/1/chromeos/dbus/permission_br...
File chromeos/dbus/permission_broker_client.h (right):

https://codereview.chromium.org/2291983002/diff/1/chromeos/dbus/permission_br...
chromeos/dbus/permission_broker_client.h:64: // permission broker can monitor
the lifetime of the calling process.
On 2016/08/31 05:18:08, satorux1 wrote:
> add some comment about |lifeline_fd| like you did with the debug daemon
client?
> 
> // This method duplicates |lifeline_fd| so it's OK to close the FD
> // withoutwaiting for the result.

Done.
Also reworded the existing comments to avoid confusion about 2 FDs on each pipe.

https://codereview.chromium.org/2291983002/diff/1/device/usb/usb_device_linux.cc
File device/usb/usb_device_linux.cc (right):

https://codereview.chromium.org/2291983002/diff/1/device/usb/usb_device_linux...
device/usb/usb_device_linux.cc:96: }
On 2016/08/30 15:45:59, stevenjb wrote:
> nit: invert if and early exit, no else.

Done.

[hashimoto, 2016-08-31 07:09:32]

The CQ bit was checked by hashimoto@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-31 07:09:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hashimoto, 2016-08-31 08:04:12]

hashimoto@chromium.org changed reviewers:
+ reillyg@chromium.org

[hashimoto, 2016-08-31 08:04:13]

reillyg@, could you review this change as an owner of device/?

[commit-bot: I haz the power, 2016-08-31 08:13:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-31 08:13:16]

Dry run: This issue passed the CQ dry run.

[Reilly Grant (use Gerrit), 2016-08-31 15:53:44]

lgtm but before landing this change please do a sanity check and make sure you
can use the gnubbyd app to switch a gnubby between HID and USB firmwares a few
times.

[hashimoto, 2016-09-01 02:02:40]

On 2016/08/31 15:53:44, Reilly Grant wrote:
> lgtm but before landing this change please do a sanity check and make sure you
> can use the gnubbyd app to switch a gnubby between HID and USB firmwares a few
> times.

Thanks, done.
I could switch between HID and USB a few times.

[hashimoto, 2016-09-01 02:02:46]

The CQ bit was checked by hashimoto@chromium.org

[hashimoto, 2016-09-01 02:02:46]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org, satorux@chromium.org
Link to the patchset: https://codereview.chromium.org/2291983002/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2016-09-01 02:03:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-01 02:07:29]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-09-01 02:09:10]

Description was changed from

==========
chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient

Replace dbus::FileDescriptor with base::ScopedFD

BUG=621841
==========

to

==========
chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient

Replace dbus::FileDescriptor with base::ScopedFD

BUG=621841

Committed: https://crrev.com/1568856ab34e9581e2a7e0cf86116d3c23d0640e
Cr-Commit-Position: refs/heads/master@{#415847}
==========

[commit-bot: I haz the power, 2016-09-01 02:09:11]

Patchset 3 (id:??) landed as
https://crrev.com/1568856ab34e9581e2a7e0cf86116d3c23d0640e
Cr-Commit-Position: refs/heads/master@{#415847}