Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Unified Diff: chromeos/dbus/permission_broker_client.cc

Issue 2291983002: chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient (Closed)
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chromeos/dbus/permission_broker_client.h ('k') | chromeos/network/firewall_hole.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chromeos/dbus/permission_broker_client.cc
diff --git a/chromeos/dbus/permission_broker_client.cc b/chromeos/dbus/permission_broker_client.cc
index c56d801da8f36e0966b854696b9c87c5aaf1bfc2..408a7bab0f0abcdd59090150d1baa6659b7dcdb1 100644
--- a/chromeos/dbus/permission_broker_client.cc
+++ b/chromeos/dbus/permission_broker_client.cc
@@ -61,7 +61,7 @@ class PermissionBrokerClientImpl : public PermissionBrokerClient {
void RequestTcpPortAccess(uint16_t port,
const std::string& interface,
- const dbus::FileDescriptor& lifeline_fd,
+ int lifeline_fd,
const ResultCallback& callback) override {
dbus::MethodCall method_call(kPermissionBrokerInterface,
kRequestTcpPortAccess);
@@ -76,7 +76,7 @@ class PermissionBrokerClientImpl : public PermissionBrokerClient {
void RequestUdpPortAccess(uint16_t port,
const std::string& interface,
- const dbus::FileDescriptor& lifeline_fd,
+ int lifeline_fd,
const ResultCallback& callback) override {
dbus::MethodCall method_call(kPermissionBrokerInterface,
kRequestUdpPortAccess);
@@ -139,7 +139,7 @@ class PermissionBrokerClientImpl : public PermissionBrokerClient {
void OnOpenPathResponse(const OpenPathCallback& callback,
dbus::Response* response) {
- dbus::FileDescriptor fd;
+ base::ScopedFD fd;
dbus::MessageReader reader(response);
if (!reader.PopFileDescriptor(&fd))
LOG(WARNING) << "Could not parse response: " << response->ToString();
« no previous file with comments | « chromeos/dbus/permission_broker_client.h ('k') | chromeos/network/firewall_hole.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698