Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2075)

Unified Diff: device/serial/serial_io_handler.h

Issue 2291983002: chromeos: Remove dbus::FileDescriptor from PermissionBrokerClient (Closed)
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/hid/hid_service_linux.cc ('k') | device/serial/serial_io_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/serial/serial_io_handler.h
diff --git a/device/serial/serial_io_handler.h b/device/serial/serial_io_handler.h
index 6d94e6fdb1ac04374f1fc4744ce2f7c1273617b5..ae2f82c8dcbac5fe2f89e3a3296f2233fddc036f 100644
--- a/device/serial/serial_io_handler.h
+++ b/device/serial/serial_io_handler.h
@@ -20,10 +20,6 @@
#include "device/serial/buffer.h"
#include "device/serial/serial.mojom.h"
-namespace dbus {
-class FileDescriptor;
-}
-
namespace device {
// Provides a simplified interface for performing asynchronous I/O on serial
@@ -48,9 +44,8 @@ class SerialIoHandler : public base::NonThreadSafe,
#if defined(OS_CHROMEOS)
// Signals that the port has been opened.
void OnPathOpened(
- scoped_refptr<base::SingleThreadTaskRunner> file_thread_task_runner,
scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,
- dbus::FileDescriptor fd);
+ base::ScopedFD fd);
// Signals that the permission broker failed to open the port.
void OnPathOpenError(
@@ -58,11 +53,6 @@ class SerialIoHandler : public base::NonThreadSafe,
const std::string& error_name,
const std::string& error_message);
- // Validates the file descriptor provided by the permission broker.
- void ValidateOpenPort(
- scoped_refptr<base::SingleThreadTaskRunner> io_thread_task_runner,
- dbus::FileDescriptor fd);
-
// Reports the open error from the permission broker.
void ReportPathOpenError(const std::string& error_name,
const std::string& error_message);
« no previous file with comments | « device/hid/hid_service_linux.cc ('k') | device/serial/serial_io_handler.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698