Add bot-page stubs

Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually.
Future CLs will implement actual functionality.


BUG=631047
Committed: https://github.com/luci/luci-py/commit/5d944ff359ed0139db738fd13c07a006a10a135b

[kjlubick, 2016-08-31 18:32:07]

Description was changed from

==========
Finish adding stub for bot-page and data


BUG=
==========

to

==========
Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually. 
Future CLs will implement actual functionality. 


BUG=631047
==========

[kjlubick, 2016-08-31 18:32:07]

kjlubick@google.com changed reviewers:
+ jcgregorio@google.com, stephana@google.com

[kjlubick, 2016-08-31 19:37:33]

Description was changed from

==========
Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually. 
Future CLs will implement actual functionality. 


BUG=631047
==========

to

==========
Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually.
Future CLs will implement actual functionality.


BUG=631047
==========

[stephana, 2016-09-01 13:25:39]

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:11: This makes
calls authenticated with Oauth 2 to the swarming apis.  It parses
Based on our recent discussion about JS conventions, wouldn't this better in JS
as part of the bot-page element or a sub element.

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:19: Contains the
following fields: "event_type", "message", "ts" (timestamp),
If it's easily available, it would be helpful to just paste an example of the
underlying JSON object here.

[kjlubick, 2016-09-01 14:32:29]

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:11: This makes
calls authenticated with Oauth 2 to the swarming apis.  It parses
On 2016/09/01 at 13:25:39, stephana wrote:
> Based on our recent discussion about JS conventions, wouldn't this better in
JS as part of the bot-page element or a sub element.

The Skia element status-sk originally had everything in one file and it was a
monolithic mess.  Keeping the logic that fetches and parses the data separate
from the display of the data is way easier for me to understand and maintain.

If this element were more simple, I would be more likely to agree, but this
element will not be trivial.  So far (in a future CL), it is about 250 LOC.

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:19: Contains the
following fields: "event_type", "message", "ts" (timestamp),
On 2016/09/01 at 13:25:39, stephana wrote:
> If it's easily available, it would be helpful to just paste an example of the
underlying JSON object here.

I think they are a bit long to inline.  If you run `make run`, the Makefile will
download sample data to inspect.

[stephana, 2016-09-01 14:48:35]

LGTM

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
File appengine/swarming/elements/res/imp/botpage/bot-page-data.html (right):

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:11: This makes
calls authenticated with Oauth 2 to the swarming apis.  It parses
On 2016/09/01 14:32:29, kjlubick wrote:
> On 2016/09/01 at 13:25:39, stephana wrote:
> > Based on our recent discussion about JS conventions, wouldn't this better in
> JS as part of the bot-page element or a sub element.
> 
> The Skia element status-sk originally had everything in one file and it was a
> monolithic mess.  Keeping the logic that fetches and parses the data separate
> from the display of the data is way easier for me to understand and maintain.
> 
> If this element were more simple, I would be more likely to agree, but this
> element will not be trivial.  So far (in a future CL), it is about 250 LOC. 

Acknowledged.

https://codereview.chromium.org/2283133002/diff/60001/appengine/swarming/elem...
appengine/swarming/elements/res/imp/botpage/bot-page-data.html:19: Contains the
following fields: "event_type", "message", "ts" (timestamp),
On 2016/09/01 14:32:29, kjlubick wrote:
> On 2016/09/01 at 13:25:39, stephana wrote:
> > If it's easily available, it would be helpful to just paste an example of
the
> underlying JSON object here.
> 
> I think they are a bit long to inline.  If you run `make run`, the Makefile
will
> download sample data to inspect.

Acknowledged.

[jcgregorio, 2016-09-02 14:14:37]

lgtm

[KevinL, 2016-09-02 14:15:00]

kjlubick@chromium.org changed reviewers:
+ kjlubick@chromium.org

[KevinL, 2016-09-02 14:15:01]

lgtm

[KevinL, 2016-09-02 14:15:02]

The CQ bit was checked by kjlubick@chromium.org

[commit-bot: I haz the power, 2016-09-02 14:15:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-02 14:20:44]

Description was changed from

==========
Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually.
Future CLs will implement actual functionality.


BUG=631047
==========

to

==========
Add bot-page stubs

The bot-page will have only two elements - bot-page and bot-page-data

This CL has all the boilerplate, but no real content, especially visually.
Future CLs will implement actual functionality.


BUG=631047

Committed:
https://github.com/luci/luci-py/commit/5d944ff359ed0139db738fd13c07a006a10a135b
==========

[commit-bot: I haz the power, 2016-09-02 14:20:45]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-py/commit/5d944ff359ed0139db738fd13c07a006a10a135b