Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290833002: [Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled. (Closed)

Created:
4 years, 3 months ago by chanli
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

[Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled. If the falied tests are all flaky, the scheduletryjpbpipeline will return None, and so should the following pipelines. BUG=641700 Committed: https://chromium.googlesource.com/infra/infra/+/9c0770bfcdb87dc4d6511b953de330584496de44

Patch Set 1 #

Total comments: 3

Patch Set 2 : removed unwanted code. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -14 lines) Patch
M appengine/findit/waterfall/identify_try_job_culprit_pipeline.py View 2 chunks +2 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/monitor_try_job_pipeline.py View 2 chunks +3 lines, -2 lines 0 comments Download
M appengine/findit/waterfall/start_try_job_on_demand_pipeline.py View 1 2 chunks +6 lines, -10 lines 0 comments Download
M appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py View 1 chunk +15 lines, -0 lines 0 comments Download
M appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
chanli
PTAL
4 years, 3 months ago (2016-08-29 20:23:03 UTC) #2
Sharu Jiang
https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right): https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py#newcode106 appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:106: # try_job_id, try_job_result) Should these lines be removed?
4 years, 3 months ago (2016-08-29 20:53:20 UTC) #3
stgao
https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right): https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py#newcode106 appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:106: # try_job_id, try_job_result) On 2016/08/29 20:53:20, sharu jiang wrote: ...
4 years, 3 months ago (2016-08-29 21:07:11 UTC) #4
chanli
https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py File appengine/findit/waterfall/start_try_job_on_demand_pipeline.py (right): https://codereview.chromium.org/2290833002/diff/1/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py#newcode106 appengine/findit/waterfall/start_try_job_on_demand_pipeline.py:106: # try_job_id, try_job_result) On 2016/08/29 20:53:20, sharu jiang wrote: ...
4 years, 3 months ago (2016-08-29 21:27:13 UTC) #5
stgao
lgtm
4 years, 3 months ago (2016-08-29 21:36:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290833002/20001
4 years, 3 months ago (2016-08-29 22:30:39 UTC) #8
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 22:44:58 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/9c0770bfcdb87dc4d6511b953de33...

Powered by Google App Engine
This is Rietveld 408576698