Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Unified Diff: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py

Issue 2290833002: [Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled. (Closed)
Patch Set: removed unwanted code. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
diff --git a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
index f08faf95ff56410835dfc8c0195385bf8f49c0d8..49eb4cefa24f6a1586b51fdc02a36b14550b1b7e 100644
--- a/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
+++ b/appengine/findit/waterfall/start_try_job_on_demand_pipeline.py
@@ -99,11 +99,6 @@ class StartTryJobOnDemandPipeline(BasePipeline):
try_job_id = yield ScheduleCompileTryJobPipeline(
master_name, builder_name, build_number, good_revision, bad_revision,
try_job_type, compile_targets, suspected_revisions)
- try_job_result = yield MonitorTryJobPipeline(
- master_name, builder_name, build_number, try_job_type, try_job_id)
- yield IdentifyTryJobCulpritPipeline(
- master_name, builder_name, build_number, blame_list, try_job_type,
- try_job_id, try_job_result)
else:
# If try_job_type is other type, the pipeline has returned.
# So here the try_job_type is failure_type.TEST.
@@ -122,8 +117,9 @@ class StartTryJobOnDemandPipeline(BasePipeline):
try_job_id = yield ScheduleTestTryJobPipeline(
master_name, builder_name, build_number, good_revision, bad_revision,
try_job_type, suspected_revisions, *reliable_tests)
- try_job_result = yield MonitorTryJobPipeline(
- master_name, builder_name, build_number, try_job_type, try_job_id)
- yield IdentifyTryJobCulpritPipeline(
- master_name, builder_name, build_number, blame_list, try_job_type,
- try_job_id, try_job_result)
+
+ try_job_result = yield MonitorTryJobPipeline(
+ master_name, builder_name, build_number, try_job_type, try_job_id)
+ yield IdentifyTryJobCulpritPipeline(
+ master_name, builder_name, build_number, blame_list, try_job_type,
+ try_job_id, try_job_result)

Powered by Google App Engine
This is Rietveld 408576698