Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1863)

Unified Diff: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py

Issue 2290833002: [Findit] Fix a bug that MonitorTryJobPipeline still runs when no try job scheduled. (Closed)
Patch Set: removed unwanted code. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
diff --git a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
index 2372e30f7005c868715b26f8b5b7f954170bf499..4289a23f8874f9e2869ea1ed83085fdeb64f3ff5 100644
--- a/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
+++ b/appengine/findit/waterfall/test/monitor_try_job_pipeline_test.py
@@ -478,3 +478,13 @@ class MonitorTryJobPipelineTest(wf_testcase.WaterfallTestCase):
self.assertEqual(
monitor_try_job_pipeline._GetError(build_response, None, False),
(expected_error_dict, try_job_error.UNKNOWN))
+
+ def testReturnNoneIfNoTryJobId(self):
+ master_name = 'm'
+ builder_name = 'b'
+ build_number = 1
+ pipeline = MonitorTryJobPipeline()
+ test_result = pipeline.run(
+ master_name, builder_name, build_number, failure_type.TEST,
+ None)
+ self.assertIsNone(test_result)
« no previous file with comments | « appengine/findit/waterfall/test/identify_try_job_culprit_pipeline_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698