Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2290453005: service worker: Refactor blob reading out of ServiceWorkerURLRequestJob (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

service worker: Refactor blob reading out of ServiceWorkerURLRequestJob ServiceWorkerURLRequestJob has two distinct states when there is a response from the service worker: it can be reading a blob or a stream. To clarify the states, factor out blob and stream response reading into dedicated classes. This should also help netlog fit better with the superclass's "request start" vs "reading response" phases. Committed: https://crrev.com/92aa26d130fe33ef70c2f1279ffaf042c3618296 Cr-Commit-Position: refs/heads/master@{#415293}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -91 lines) Patch
A content/browser/service_worker/service_worker_blob_reader.h View 1 chunk +60 lines, -0 lines 0 comments Download
A content/browser/service_worker/service_worker_blob_reader.cc View 1 chunk +86 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.h View 5 chunks +9 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 8 chunks +28 lines, -72 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (3 generated)
falken
PTAL. The final result is to split stream and blob reading into separate classes, which ...
4 years, 3 months ago (2016-08-30 07:47:48 UTC) #2
horo
lgtm
4 years, 3 months ago (2016-08-30 09:32:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290453005/1
4 years, 3 months ago (2016-08-30 13:01:16 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 14:48:08 UTC) #6
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 14:49:53 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92aa26d130fe33ef70c2f1279ffaf042c3618296
Cr-Commit-Position: refs/heads/master@{#415293}

Powered by Google App Engine
This is Rietveld 408576698