Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 2292833002: Refactoring: service worker: Factor out some duplicated code. (Closed)

Created:
4 years, 3 months ago by falken
Modified:
4 years, 3 months ago
Reviewers:
horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, kinuko+serviceworker, horo+watch_chromium.org, darin-cc_chromium.org, kinuko+watch, blink-worker-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactoring: service worker: Factor out some duplicated code. Committed: https://crrev.com/ac369856d3707a0bf999252762556ef7d274097e Cr-Commit-Position: refs/heads/master@{#415270}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -16 lines) Patch
M content/browser/service_worker/service_worker_url_request_job.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_url_request_job.cc View 3 chunks +16 lines, -16 lines 1 comment Download

Dependent Patchsets:

Messages

Total messages: 16 (9 generated)
falken
very minor refactoring https://codereview.chromium.org/2292833002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc File content/browser/service_worker/service_worker_url_request_job.cc (right): https://codereview.chromium.org/2292833002/diff/1/content/browser/service_worker/service_worker_url_request_job.cc#newcode814 content/browser/service_worker/service_worker_url_request_job.cc:814: response_cache_storage_cache_name_ = response.cache_storage_cache_name; Previously these cache_storage ...
4 years, 3 months ago (2016-08-30 07:06:17 UTC) #2
horo
lgtm
4 years, 3 months ago (2016-08-30 09:10:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292833002/1
4 years, 3 months ago (2016-08-30 09:15:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/288857)
4 years, 3 months ago (2016-08-30 10:04:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2292833002/1
4 years, 3 months ago (2016-08-30 10:18:45 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-08-30 11:28:57 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-08-30 11:30:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/ac369856d3707a0bf999252762556ef7d274097e
Cr-Commit-Position: refs/heads/master@{#415270}

Powered by Google App Engine
This is Rietveld 408576698