Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2290453002: V8: Remove legacy mozilla svn download (Closed)

Created:
4 years, 3 months ago by Michael Achenbach
Modified:
4 years, 3 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

V8: Remove legacy mozilla svn download This is on git since a few milestones and downloaded as a standard deps. It existed on the branch builders only for backwards-compatibility. BUG=640212 Committed: https://chromium.googlesource.com/chromium/tools/build/+/f967d26d13aece61e9d11ee9b01acc84bf737010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -32 lines) Patch
M scripts/slave/recipe_modules/v8/builders.py View 2 chunks +1 line, -4 lines 0 comments Download
M scripts/slave/recipe_modules/v8/gclient_config.py View 2 chunks +1 line, -15 lines 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___beta_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux64___stable_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___beta_branch_branch_sync_failure.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_Linux___stable_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___beta_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch.json View 1 chunk +1 line, -1 line 0 comments Download
M scripts/slave/recipes/v8.expected/full_client_v8_branches_V8_arm___sim___stable_branch___debug.json View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 14 (10 generated)
Michael Achenbach
PTAL
4 years, 3 months ago (2016-08-28 19:35:40 UTC) #4
tandrii(chromium)
Nice, LGTM
4 years, 3 months ago (2016-08-28 21:46:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290453002/1
4 years, 3 months ago (2016-08-29 06:19:08 UTC) #12
commit-bot: I haz the power
4 years, 3 months ago (2016-08-29 06:22:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/f967d26d13aece61e9d1...

Powered by Google App Engine
This is Rietveld 408576698