Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1906)

Unified Diff: scripts/slave/recipe_modules/v8/builders.py

Issue 2290453002: V8: Remove legacy mozilla svn download (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/gclient_config.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/v8/builders.py
diff --git a/scripts/slave/recipe_modules/v8/builders.py b/scripts/slave/recipe_modules/v8/builders.py
index 627b3f60b8f6248bafc55d70f4422f0f0c12f80c..73951c0e4fdca2fbfd20eb54bf0752f3e0a43371 100644
--- a/scripts/slave/recipe_modules/v8/builders.py
+++ b/scripts/slave/recipe_modules/v8/builders.py
@@ -2697,7 +2697,7 @@ def AddBranchBuilder(build_config, arch, bits, presubmit=False,
tests = [V8Testing, Test262, Mozilla]
if presubmit:
tests = [Presubmit] + tests
- config = {
+ return {
'chromium_apply_config': ['default_compiler', 'v8_ninja', 'goma'],
'v8_config_kwargs': {
'BUILD_CONFIG': build_config,
@@ -2708,9 +2708,6 @@ def AddBranchBuilder(build_config, arch, bits, presubmit=False,
'tests': tests,
'testing': {'platform': 'linux'},
}
- if not unittests_only:
- config['gclient_apply_config'] = ['mozilla_tests']
- return config
for build_config, name_suffix in (('Release', ''), ('Debug', ' - debug')):
for branch_name in ('stable branch', 'beta branch'):
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/v8/gclient_config.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698