Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1094)

Unified Diff: scripts/slave/recipe_modules/v8/gclient_config.py

Issue 2290453002: V8: Remove legacy mozilla svn download (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/v8/gclient_config.py
diff --git a/scripts/slave/recipe_modules/v8/gclient_config.py b/scripts/slave/recipe_modules/v8/gclient_config.py
index 94b49ad7e37d4b79d0e2743a0dd3a0ed65bb3886..fb3d6a903c578eeeb49097d9478279cf0cfd0c1f 100644
--- a/scripts/slave/recipe_modules/v8/gclient_config.py
+++ b/scripts/slave/recipe_modules/v8/gclient_config.py
@@ -7,15 +7,7 @@ CONFIG_CTX = DEPS['gclient'].CONFIG_CTX
from recipe_engine.config import BadConf
-# TODO(machenbach): This is copied from gclient's config.py and should be
-# unified somehow.
-def ChromiumSvnSubURL(c, *pieces):
- BASES = ('https://src.chromium.org',
- 'svn://svn-mirror.golo.chromium.org')
- return '/'.join((BASES[c.USE_MIRROR],) + pieces)
-
-
-# TODO(machenbach): Remove the method above in favor of this one.
+# TODO(machenbach): Remove this.
def ChromiumSvnTrunkURL(c, *pieces):
BASES = ('https://src.chromium.org/svn/trunk',
'svn://svn-mirror.golo.chromium.org/chrome/trunk')
@@ -51,12 +43,6 @@ def llvm_compiler_rt(c):
'https://chromium.googlesource.com/external/llvm.org/compiler-rt.git')
-@CONFIG_CTX(includes=['v8'])
-def mozilla_tests(c):
- c.solutions[0].custom_deps['v8/test/mozilla/data'] = ChromiumSvnSubURL(
- c, 'chrome', 'trunk', 'deps', 'third_party', 'mozilla-tests')
-
-
@CONFIG_CTX()
def node_js(c):
soln = c.solutions.add()

Powered by Google App Engine
This is Rietveld 408576698