Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2177)

Issue 2290323004: (Manual) Revert of gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices (patchset #3 id: (Closed)

Created:
4 years, 3 months ago by robert.bradford
Modified:
4 years, 3 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

(Manual) Revert of gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices (patchset #3 id:60001 of https://codereview.chromium.org/2165553002/ ) Reason for revert: Revert as a bisect of https://crbug.com/642290 points at CMAA enabling being the cause of graphics corruption in the camera app. This CL contains the following fixups: a.) bumps the version numbers. b.) deletes the whole block for the workaround. Original issue's description: > gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices > > Extend the GPU workaround exception list to enable CMAA on all Broadwell > and Braswell GPUs. Using CMAA in place of MSAA for WebGL gives a > performance benefit. > > BUG=535198 > TEST=Boot cyan and observe that workaround is no longer listed. > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Committed: https://crrev.com/58b5a5253da3242e0ff3bc2e7b963e55efc5bbd4 > Cr-Commit-Position: refs/heads/master@{#414435} TBR=kbr@chromium.org,marcheu@chromium.org BUG=535198, 642290 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Patch Set 1 #

Patch Set 2 : Manual resolve of revert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -22 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +1 line, -22 lines 0 comments Download

Messages

Total messages: 13 (10 generated)
robert.bradford
Created Revert of gpu: Enable CMAA for all Broadwell and Braswell ChromeOS devices
4 years, 3 months ago (2016-08-31 12:17:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290323004/1
4 years, 3 months ago (2016-08-31 12:19:36 UTC) #4
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 12:21:15 UTC) #6
Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

Powered by Google App Engine
This is Rietveld 408576698