gpu: Use workarounds to selectively enable CMAA

gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/0885aff9905de9b96b197c353d4f438c173b5834
Cr-Commit-Position: refs/heads/master@{#402913}

[robert.bradford, 2016-06-29 16:20:59]

Description was changed from

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
and with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
==========

to

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
and with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[robert.bradford, 2016-06-29 16:24:15]

robert.bradford@intel.com changed reviewers:
+ zmo@chromium.org

[robert.bradford, 2016-06-29 16:24:16]

Hi zmo@ here is the CL enabling CMAA on samus devices using the method you
proposed on the bug.

I have kept the commandline flag for now but as we get wider range I plan to
remove it. Please take a look at this change when you can.

[Zhenyao Mo, 2016-06-29 16:59:16]

Mostly looks good

https://codereview.chromium.org/2112513003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2112513003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:895: } else if
((enable_cmaa_shaders_switch_ ||
You should just get rid of this enable_cmaa_shaders_switch_ and its related code
now that we have the driver bug workaround installed.

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.73",
Please update the version to 8.74

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:1862: "type": "any"
No need to specify "os" at all if it's any.

[robert.bradford, 2016-06-29 17:39:46]

robert.bradford@intel.com changed reviewers:
+ piman@chromium.org

[robert.bradford, 2016-06-29 17:39:46]

Hi zmo@ all done! piman@ could you review the changes in ui/gl?

https://codereview.chromium.org/2112513003/diff/1/gpu/command_buffer/service/...
File gpu/command_buffer/service/feature_info.cc (right):

https://codereview.chromium.org/2112513003/diff/1/gpu/command_buffer/service/...
gpu/command_buffer/service/feature_info.cc:895: } else if
((enable_cmaa_shaders_switch_ ||
On 2016/06/29 16:59:16, Zhenyao Mo wrote:
> You should just get rid of this enable_cmaa_shaders_switch_ and its related
code
> now that we have the driver bug workaround installed.

Done.

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
File gpu/config/gpu_driver_bug_list_json.cc (right):

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:22: "version": "8.73",
On 2016/06/29 16:59:16, Zhenyao Mo wrote:
> Please update the version to 8.74

Done.

https://codereview.chromium.org/2112513003/diff/1/gpu/config/gpu_driver_bug_l...
gpu/config/gpu_driver_bug_list_json.cc:1862: "type": "any"
On 2016/06/29 16:59:16, Zhenyao Mo wrote:
> No need to specify "os" at all if it's any.

Done.

[Zhenyao Mo, 2016-06-29 17:44:20]

lgtm

[Zhenyao Mo, 2016-06-29 17:44:26]

The CQ bit was checked by zmo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 17:46:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-06-29 17:47:50]

lgtm

lgtm

lgtm

[robert.bradford, 2016-06-29 18:18:06]

Description was changed from

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
and with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-29 19:09:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 19:09:22]

Dry run: This issue passed the CQ dry run.

[robert.bradford, 2016-06-29 19:44:08]

The CQ bit was checked by robert.bradford@intel.com

[commit-bot: I haz the power, 2016-06-29 19:47:04]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 19:57:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 19:59:19]

Description was changed from

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel
==========

to

==========
gpu: Use workarounds to selectively enable CMAA

To get wider testing of the impact of using CMAA for WebGL selectively
enable it by default for "Broadwell GT2" ChromeOS devices.

This was achieved by adding a workaround disabling CMAA on all devices
with an exception for the GPU found in ChromeOS devices like samus.

BUG=535198
TEST=Boot samus device and with added logging observe that CMAA is
activated for WebGL. Use --gpu-testing-device-id/--gpu-testing-vendor-id
to override the device ID and observe "disable_framebuffer_cmaa" listed
under "Driver Bug Workarounds."
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel

Committed: https://crrev.com/0885aff9905de9b96b197c353d4f438c173b5834
Cr-Commit-Position: refs/heads/master@{#402913}
==========

[commit-bot: I haz the power, 2016-06-29 19:59:20]

Patchset 2 (id:??) landed as
https://crrev.com/0885aff9905de9b96b197c353d4f438c173b5834
Cr-Commit-Position: refs/heads/master@{#402913}