Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2290313002: Remove PlatformKeyboardEvent (Closed)

Created:
4 years, 3 months ago by dtapuska
Modified:
4 years, 3 months ago
Reviewers:
esprehn
CC:
aboxhall, apavlov+blink_chromium.org, blink-reviews, blink-reviews-api_chromium.org, blink-reviews-dom_chromium.org, blink-reviews-events_chromium.org, blink-reviews-layout_chromium.org, caseq+blink_chromium.org, chromium-reviews, dcheng, devtools-reviews_chromium.org, dglazkov+blink, dmazzoni, dtapuska+blinkwatch_chromium.org, eae+blinkwatch, jchaffraix+rendering, je_julie, kinuko+watch, kozyatinskiy+blink_chromium.org, leviw+renderwatch, lushnikov+blink_chromium.org, mlamouri+watch-blink_chromium.org, nektarios, nzolghadr+blinkwatch_chromium.org, pdr+renderingwatchlist_chromium.org, pfeldman+blink_chromium.org, rwlbuis, sof, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove PlatformKeyboardEvent Remove abstraction for PlatformKeyboardEvent and use WebKeyboardEvent directly inside core. BUG=625684 Committed: https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d Cr-Commit-Position: refs/heads/master@{#415535}

Patch Set 1 #

Patch Set 2 : Fix mac and windows builds #

Patch Set 3 : Really fix windows and mac now #

Patch Set 4 : One more fix #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -547 lines) Patch
M third_party/WebKit/Source/core/dom/Node.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/EditingBehavior.cpp View 7 chunks +13 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.h View 5 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/events/KeyboardEvent.cpp View 4 chunks +28 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/EventHandler.cpp View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.h View 2 chunks +22 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/input/KeyboardEventManager.cpp View 1 2 3 7 chunks +89 lines, -17 lines 1 comment Download
M third_party/WebKit/Source/core/inspector/InspectorInputAgent.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTextControlSingleLine.cpp View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/testing/Internals.cpp View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/PlatformEvent.h View 1 chunk +0 lines, -6 lines 0 comments Download
D third_party/WebKit/Source/platform/PlatformKeyboardEvent.h View 1 chunk +0 lines, -117 lines 0 comments Download
D third_party/WebKit/Source/platform/PlatformKeyboardEvent.cpp View 1 chunk +0 lines, -131 lines 0 comments Download
M third_party/WebKit/Source/platform/blink_platform.gypi View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebAXObject.cpp View 3 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.h View 3 chunks +1 line, -10 lines 0 comments Download
M third_party/WebKit/Source/web/WebInputEventConversion.cpp View 3 chunks +10 lines, -95 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.h View 4 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 2 chunks +4 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/WebViewImpl.cpp View 1 2 5 chunks +7 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/tests/KeyboardTest.cpp View 3 chunks +20 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/web/tests/WebPluginContainerTest.cpp View 3 chunks +12 lines, -7 lines 0 comments Download
M third_party/WebKit/public/platform/WebInputEvent.h View 2 chunks +39 lines, -17 lines 0 comments Download

Messages

Total messages: 24 (19 generated)
dtapuska
4 years, 3 months ago (2016-08-30 20:22:00 UTC) #16
esprehn
lgtm https://codereview.chromium.org/2290313002/diff/60001/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp File third_party/WebKit/Source/core/input/KeyboardEventManager.cpp (right): https://codereview.chromium.org/2290313002/diff/60001/third_party/WebKit/Source/core/input/KeyboardEventManager.cpp#newcode325 third_party/WebKit/Source/core/input/KeyboardEventManager.cpp:325: return GetKeyState(VK_CAPITAL) & 1; I hope we have ...
4 years, 3 months ago (2016-08-30 20:30:28 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2290313002/60001
4 years, 3 months ago (2016-08-31 01:48:33 UTC) #21
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-08-31 01:53:47 UTC) #22
commit-bot: I haz the power
4 years, 3 months ago (2016-08-31 01:56:17 UTC) #24
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/98ec378a9fcf5d0ace4f82d4c2e9aaafc4be492d
Cr-Commit-Position: refs/heads/master@{#415535}

Powered by Google App Engine
This is Rietveld 408576698