Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp

Issue 2290313002: Remove PlatformKeyboardEvent (Closed)
Patch Set: One more fix Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
index 589c314f62ddb710bfe4845ddd83bf5c0d5b22c7..2a19b41b9f3a92721a4fb9ae4d2853896270d5ff 100644
--- a/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
+++ b/third_party/WebKit/Source/core/editing/EditorKeyBindings.cpp
@@ -30,21 +30,21 @@
#include "core/events/KeyboardEvent.h"
#include "core/frame/LocalFrame.h"
#include "core/page/EditorClient.h"
-#include "platform/PlatformKeyboardEvent.h"
+#include "public/platform/WebInputEvent.h"
namespace blink {
bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt)
{
- const PlatformKeyboardEvent* keyEvent = evt->keyEvent();
+ const WebKeyboardEvent* keyEvent = evt->keyEvent();
// do not treat this as text input if it's a system key event
- if (!keyEvent || keyEvent->isSystemKey())
+ if (!keyEvent || keyEvent->isSystemKey)
return false;
String commandName = behavior().interpretKeyEvent(*evt);
Command command = this->createCommand(commandName);
- if (keyEvent->type() == PlatformEvent::RawKeyDown) {
+ if (keyEvent->type == WebInputEvent::RawKeyDown) {
// WebKit doesn't have enough information about mode to decide how
// commands that just insert text if executed via Editor should be treated,
// so we leave it upon WebCore to either handle them immediately
@@ -62,10 +62,10 @@ bool Editor::handleEditingKeyboardEvent(KeyboardEvent* evt)
return false;
// Return true to prevent default action. e.g. Space key scroll.
- if (dispatchBeforeInputInsertText(evt->target(), evt->keyEvent()->text()) != DispatchEventResult::NotCanceled)
+ if (dispatchBeforeInputInsertText(evt->target(), keyEvent->text) != DispatchEventResult::NotCanceled)
return true;
- return insertText(evt->keyEvent()->text(), evt);
+ return insertText(keyEvent->text, evt);
}
void Editor::handleKeyboardEvent(KeyboardEvent* evt)

Powered by Google App Engine
This is Rietveld 408576698